Bug 1531499 - additional workaround for Windows 32bit incorrectly reporting failure for reftest r=jmaher,ahal
authorEdwin Gao <egao@mozilla.com>
Fri, 01 Mar 2019 13:58:52 +0000
changeset 519863 bd930453714efe8f6aa756938c1c09a24ec79cd4
parent 519862 47629d4e3150e77e91201d93d5d9e8b7cda8f909
child 519864 ad25e831bd26dae15f44c7224004749a13099032
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher, ahal
bugs1531499
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531499 - additional workaround for Windows 32bit incorrectly reporting failure for reftest r=jmaher,ahal Changes: - modified the criteria for using 1 as the successful return code by using a combination of factors; is it Windows, is it 32bit, and is it Reftest. Differential Revision: https://phabricator.services.mozilla.com/D21596
testing/mozharness/scripts/desktop_unittest.py
--- a/testing/mozharness/scripts/desktop_unittest.py
+++ b/testing/mozharness/scripts/desktop_unittest.py
@@ -927,19 +927,21 @@ class DesktopUnittest(TestingMixin, Merc
                     # be. We do this by:
                     # 1) checking to see if our mozharness script ran into any
                     #    errors itself with 'num_errors' <- OutputParser
                     # 2) if num_errors is 0 then we look in the subclassed 'parser'
                     #    findings for harness/suite errors <- DesktopUnittestOutputParser
                     # 3) checking to see if the return code is in success_codes
 
                     success_codes = None
-                    if suite_category == 'reftest' and platform.platform().startswith('Windows-7'):
-                        # bug 1120644
-                        success_codes = [0, 1]
+                    if (suite_category == 'reftest'
+                            and '32bit' in platform.architecture()
+                            and platform.system() == "Windows"):
+                        # see bug 1120644, 1526777, 1531499
+                        success_codes = [1]
 
                     tbpl_status, log_level, summary = parser.evaluate_parser(return_code,
                                                                              success_codes,
                                                                              summary)
                     parser.append_tinderboxprint_line(suite_name)
 
                     self.record_status(tbpl_status, level=log_level)
                     if len(per_test_args) > 0: