Follow-up patch 3 to bug 1041631 part 1. Make two more tests pass when Symbol is not defined. r=efaust.
authorJason Orendorff <jorendorff@mozilla.com>
Fri, 29 Aug 2014 16:22:29 -0500
changeset 224166 bd847dedd1e5028846479632f5575ce6ee9f085f
parent 224165 4911e706d5599cd71f6053285d35a023b2443d71
child 224167 4122a2e5ec865f3453076e7d88c49ea311d48f93
push id3979
push userraliiev@mozilla.com
push dateMon, 13 Oct 2014 16:35:44 +0000
treeherdermozilla-beta@30f2cc610691 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersefaust
bugs1041631
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Follow-up patch 3 to bug 1041631 part 1. Make two more tests pass when Symbol is not defined. r=efaust.
js/src/jit-test/tests/ion/bug1054753.js
toolkit/devtools/server/tests/unit/test_symbols-01.js
--- a/js/src/jit-test/tests/ion/bug1054753.js
+++ b/js/src/jit-test/tests/ion/bug1054753.js
@@ -6,9 +6,11 @@ if (typeof Symbol === "function") {
             Int32ArrayView[Symbol() >> 2]
         }
         return f;
     })();
     try {
         g();
     } catch (e) {}
     g();
+} else {
+    throw new TypeError("pass");
 }
--- a/toolkit/devtools/server/tests/unit/test_symbols-01.js
+++ b/toolkit/devtools/server/tests/unit/test_symbols-01.js
@@ -18,16 +18,22 @@ function run_test() {
       run_next_test();
     });
   });
 
   do_test_pending();
 }
 
 function* testSymbols(client, debuggee) {
+  // Symbol is conditionally defined. If it isn't defined in this build, just pass.
+  if (typeof Symbol === "undefined") {
+    finishClient(client);
+    return;
+  }
+
   const evalCode = () => {
     Components.utils.evalInSandbox(
       "(" + function () {
         var symbolWithName = Symbol("Chris");
         var symbolWithoutName = Symbol();
         var iteratorSymbol = Symbol.iterator;
         debugger;
       } + "())",