Bug 848861 - Send stack traces with FHR errors; r=rnewman, sr=mconnor
authorGregory Szorc <gps@mozilla.com>
Mon, 18 Mar 2013 15:07:07 -0700
changeset 135700 bcf9c06aa2cb8518c9778ec73f0856c2f3260786
parent 135699 4dff991eac0981d95901ff126adff025d383bac6
child 135701 cb810d07bc933d3a245535546ca0a3144adde3ad
push id2452
push userlsblakk@mozilla.com
push dateMon, 13 May 2013 16:59:38 +0000
treeherdermozilla-beta@d4b152d29d8d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrnewman, mconnor
bugs848861
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 848861 - Send stack traces with FHR errors; r=rnewman, sr=mconnor
services/healthreport/healthreporter.jsm
services/metrics/providermanager.jsm
--- a/services/healthreport/healthreporter.jsm
+++ b/services/healthreport/healthreporter.jsm
@@ -452,17 +452,17 @@ AbstractHealthReporter.prototype = Objec
    * @param ex
    *        (Error) The error that should be captured.
    */
   _recordError: function (message, ex) {
     let recordMessage = message;
     let logMessage = message;
 
     if (ex) {
-      recordMessage += ": " + ex.message;
+      recordMessage += ": " + CommonUtils.exceptionStr(ex);
       logMessage += ": " + CommonUtils.exceptionStr(ex);
     }
 
     // Scrub out potentially identifying information from strings that could
     // make the payload.
     let appData = Services.dirsvc.get("UAppData", Ci.nsIFile);
     let profile = Services.dirsvc.get("ProfD", Ci.nsIFile);
 
--- a/services/metrics/providermanager.jsm
+++ b/services/metrics/providermanager.jsm
@@ -407,17 +407,17 @@ this.ProviderManager.prototype = Object.
   },
 
   /**
    * Record an error that occurred operating on a provider.
    */
   _recordProviderError: function (name, msg, ex) {
     let msg = "Provider error: " + name + ": " + msg;
     if (ex) {
-      msg += ": " + ex.message;
+      msg += ": " + CommonUtils.exceptionStr(ex);
     }
     this._log.warn(msg);
 
     if (this.onProviderError) {
       try {
         this.onProviderError(msg);
       } catch (callError) {
         this._log.warn("Exception when calling onProviderError callback: " +