Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button. r=sebastian, a=sylvestre
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 12 May 2016 10:56:50 -0700
changeset 333093 bcf1d6fa8fee4a885d7c5d5393b0560ace064bd6
parent 333092 ccf0f53adb66c86d81a39b53e32092489fb5f0b5
child 333094 b235305398fdb8d0cd91087d2d5fa1109f9e0784
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian, sylvestre
bugs1272391
milestone48.0a2
Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button. r=sebastian, a=sylvestre I didn't pay attention while copying telemetry events. We send cancel when dismissing the prompt, action when the user selects the suggested prompt action. MozReview-Commit-ID: IAOMRRemCiz
mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
--- a/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
+++ b/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
@@ -110,17 +110,17 @@ public class SimpleHelperUI extends Loca
 
         final Button button = ((Button) findViewById(R.id.button));
         button.setText(i.getIntExtra(EXTRA_BUTTON, 0));
         button.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
                 slideOut();
 
-                Telemetry.sendUIEvent(TelemetryContract.Event.CANCEL, TelemetryContract.Method.BUTTON, mTelemetryExtra);
+                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, mTelemetryExtra);
 
                 setResult(i.getIntExtra(EXTRA_RESULTCODE_POSITIVE, -1));
             }
         });
     }
 
     private void slideIn() {
         containerView.setTranslationY(500);