Bug 1396831 - Align HTTP status codes with specification. r=jgraham
authorAndreas Tolfsen <ato@sny.no>
Tue, 05 Sep 2017 14:42:12 +0100
changeset 428420 bcd74edc5749d59828144f1414411022f1e4f5b5
parent 428419 b763a58280a37f70028284d2755036dd3ce806ac
child 428421 51d6923fc31466dbaa7a427c16424ed4006ae8b9
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1396831
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1396831 - Align HTTP status codes with specification. r=jgraham Some of the HTTP status codes have changed in the WebDriver specification, as shown in: https://github.com/w3c/webdriver/commit/d678562e3d5f94fa71d74aeb467214bf8dd734e1 MozReview-Commit-ID: 4DLkYDXckew
testing/webdriver/src/error.rs
--- a/testing/webdriver/src/error.rs
+++ b/testing/webdriver/src/error.rs
@@ -189,21 +189,21 @@ impl ErrorStatus {
             InvalidArgument => BadRequest,
             InvalidCookieDomain => BadRequest,
             InvalidCoordinates => BadRequest,
             InvalidElementState => BadRequest,
             InvalidSelector => BadRequest,
             InvalidSessionId => NotFound,
             JavascriptError => InternalServerError,
             MoveTargetOutOfBounds => InternalServerError,
-            NoSuchAlert => BadRequest,
+            NoSuchAlert => NotFound,
             NoSuchCookie => NotFound,
             NoSuchElement => NotFound,
-            NoSuchFrame => BadRequest,
-            NoSuchWindow => BadRequest,
+            NoSuchFrame => NotFound,
+            NoSuchWindow => NotFound,
             ScriptTimeout => RequestTimeout,
             SessionNotCreated => InternalServerError,
             StaleElementReference => BadRequest,
             Timeout => RequestTimeout,
             UnableToCaptureScreen => BadRequest,
             UnableToSetCookie => InternalServerError,
             UnexpectedAlertOpen => InternalServerError,
             UnknownCommand => NotFound,