Add a comment next to XDR_BYTECODE_VERSION directing people changing it to update the bytecode docs wiki page as well. No bug, r=trivial
authorJeff Walden <jwalden@mit.edu>
Wed, 04 Jun 2014 12:50:41 -0700
changeset 205913 bca6f69d9d7f63f879dc08945ce58dcd49625303
parent 205912 cef421d919f169847f1eb80828c39813ce7867ea
child 205914 6ae8f9e034ad5bb763af81ae771519fdf2fc1660
push id3741
push userasasaki@mozilla.com
push dateMon, 21 Jul 2014 20:25:18 +0000
treeherdermozilla-beta@4d6f46f5af68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstrivial
milestone32.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Add a comment next to XDR_BYTECODE_VERSION directing people changing it to update the bytecode docs wiki page as well. No bug, r=trivial
CLOBBER
js/src/vm/Xdr.h
--- a/CLOBBER
+++ b/CLOBBER
@@ -17,10 +17,9 @@
 #
 # Modifying this file will now automatically clobber the buildbot machines \o/
 #
 
 # Are you updating CLOBBER because you think it's needed for your WebIDL
 # changes to stick? As of bug 928195, this shouldn't be necessary! Please
 # don't change CLOBBER for WebIDL changes any more.
 
-Bug 934423 hit yet another instance of bug 1019955.
-
+Preemptive clobber for a vm/Xdr.h change to evade bug 1019955 (should it have otherwise arisen, which is unclear).
--- a/js/src/vm/Xdr.h
+++ b/js/src/vm/Xdr.h
@@ -13,20 +13,25 @@
 #include "jsatom.h"
 
 namespace js {
 
 /*
  * Bytecode version number. Increment the subtrahend whenever JS bytecode
  * changes incompatibly.
  *
- * This version number is XDR'd near the front of xdr bytecode and
- * aborts deserialization if there is a mismatch between the current
- * and saved versions. If deserialization fails, the data should be
- * invalidated if possible.
+ * This version number is XDR'd near the front of xdr bytecode and aborts
+ * deserialization if there is a mismatch between the current and saved
+ * versions.  If deserialization fails, the data should be invalidated if
+ * possible.
+ *
+ * When you change this, run make_opcode_doc.py and copy the new output into
+ * this wiki page:
+ *
+ *  https://developer.mozilla.org/en-US/docs/SpiderMonkey/Internals/Bytecode
  */
 static const uint32_t XDR_BYTECODE_VERSION = uint32_t(0xb973c0de - 173);
 
 class XDRBuffer {
   public:
     explicit XDRBuffer(JSContext *cx)
       : context(cx), base(nullptr), cursor(nullptr), limit(nullptr) { }