Bug 1484085 - don't log failure to obtain clients engine. r=tcsc
authorMark Hammond <mhammond@skippinet.com.au>
Thu, 23 Aug 2018 02:00:27 +0000
changeset 488078 bca1895bb276e2f50401f2838ecb42d38b3d9c20
parent 488077 fa1966cf5f5c2efe0475c5d684f619ccde2e3779
child 488088 32c6c1848f149454182911c6635b42956cf719de
child 488092 443c8f1e261efdd616aed67765d181a483a674ff
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstcsc
bugs1484085
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1484085 - don't log failure to obtain clients engine. r=tcsc MozReview-Commit-ID: Aj31c1OZnFf Differential Revision: https://phabricator.services.mozilla.com/D3657
services/sync/modules/engines.js
--- a/services/sync/modules/engines.js
+++ b/services/sync/modules/engines.js
@@ -488,24 +488,17 @@ EngineManager.prototype = {
         let engine = this.get(name);
         if (engine) {
           engines.push(engine);
         }
       }, this);
       return engines;
     }
 
-    let engine = this._engines[name];
-    if (!engine) {
-      this._log.debug("Could not get engine: " + name);
-      if (Object.keys) {
-        this._log.debug("Engines are: " + JSON.stringify(Object.keys(this._engines)));
-      }
-    }
-    return engine;
+    return this._engines[name]; // Silently returns undefined for unknown names.
   },
 
   getAll() {
     let engines = [];
     for (let [, engine] of Object.entries(this._engines)) {
       engines.push(engine);
     }
     return engines;