Bug 1089613 - Never treat warnings as errors in clang-cl; r=gps
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 28 Oct 2014 09:43:45 -0400
changeset 237000 bc42f690b6268ef3942cff66c008b0d24bb4116e
parent 236999 35a1f6bfbf8aaaf363a23fff81d0826355325fca
child 237001 178efc7a2007b169fb6875b8bcce88ad06e9defd
push id4311
push userraliiev@mozilla.com
push dateMon, 12 Jan 2015 19:37:41 +0000
treeherdermozilla-beta@150c9fed433b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1089613
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1089613 - Never treat warnings as errors in clang-cl; r=gps clang-cl warns about many more things than MSVC does, and supporting warnings as errors there requires some work.
config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -414,18 +414,22 @@ endif # WINNT && (MOS_PROFILE_GENERATE ^
 ifdef FAIL_ON_WARNINGS_DEBUG
 ifdef MOZ_DEBUG
 FAIL_ON_WARNINGS = 1
 endif # MOZ_DEBUG
 endif # FAIL_ON_WARNINGS_DEBUG
 
 # Check for normal version of flag, and add WARNINGS_AS_ERRORS if it's set to 1.
 ifdef FAIL_ON_WARNINGS
+# Never treat warnings as errors in clang-cl, because it warns about many more
+# things than MSVC does.
+ifndef CLANG_CL
 CXXFLAGS += $(WARNINGS_AS_ERRORS)
 CFLAGS   += $(WARNINGS_AS_ERRORS)
+endif # CLANG_CL
 endif # FAIL_ON_WARNINGS
 
 ifeq ($(OS_ARCH)_$(GNU_CC),WINNT_)
 #// Currently, unless USE_STATIC_LIBS is defined, the multithreaded
 #// DLL version of the RTL is used...
 #//
 #//------------------------------------------------------------------------
 ifdef USE_STATIC_LIBS