Fix a typo in SanityTest.js causing skewed Telemetry data. (bug 1191613, r=mchang)
authorDavid Anderson <danderson@mozilla.com>
Thu, 06 Aug 2015 13:07:36 -0700
changeset 288346 bb8a643c7096e23c0356f0e7a2f1e9a65ffac45e
parent 288345 2debc63507da51f9f884a0e6e7c3bd9bac254dc3
child 288347 c5669c73fabdf6fcbe44ae75b35875dc8d561303
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmchang
bugs1191613
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Fix a typo in SanityTest.js causing skewed Telemetry data. (bug 1191613, r=mchang)
toolkit/components/gfx/SanityTest.js
--- a/toolkit/components/gfx/SanityTest.js
+++ b/toolkit/components/gfx/SanityTest.js
@@ -239,21 +239,21 @@ SanityTest.prototype = {
 
     if (Preferences.get(RUNNING_PREF, false)) {
       Preferences.set(DISABLE_VIDEO_PREF, true);
       reportResult(TEST_CRASHED);
       return false;
     }
 
     function checkPref(pref, value, reason) {
-      var prefValue = Preferences.get(pref, "");
+      var prefValue = Preferences.get(pref, undefined);
       if (prefValue == value) {
         return true;
       }
-      if (value == "") {
+      if (prefValue === undefined) {
         reportTestReason(REASON_FIRST_RUN);
       } else {
         reportTestReason(reason);
       }
       return false;
     }
 
     // TODO: Handle dual GPU setups