Bug 1454511 - Widen valgrind suppression for selector parsing. r=njn
authorBobby Holley <bobbyholley@gmail.com>
Wed, 04 Apr 2018 16:40:24 -0700
changeset 467529 bb4fe8662ae37b2dd680f2d7383d81e1d3008c5f
parent 467528 0b6f99cbcab6dc1c0366fee97b8bb9928d3cf322
child 467530 529b9c25a0c2497dd6721f0794481eeb06be5173
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1454511
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1454511 - Widen valgrind suppression for selector parsing. r=njn The existing suppression tries to be specific about the callstack that arrives at the function, but that breaks when we rejigger the machinery up the callstack. In practice, the existing suppressions cover most of the ways we would arrive at selector parsing, and so I think the specificity here is more trouble than it's worth. MozReview-Commit-ID: 2k52xq64SQX
build/valgrind/x86_64-pc-linux-gnu.sup
--- a/build/valgrind/x86_64-pc-linux-gnu.sup
+++ b/build/valgrind/x86_64-pc-linux-gnu.sup
@@ -484,31 +484,19 @@
    fun:*style*parse_into*
    fun:*geckoservo*parse_property_into*
 }
 
 ##########################################
 # Suppressions rooted at *selectors*parser*SelectorList*Impl*parse*
 
 {
-   bug1447137-15
+   bug1454511
    Memcheck:Cond
    fun:*selectors*parser*SelectorList*Impl*parse*
-   fun:*style*parse_nested_rules*
-   fun:*style*parse_block*
-   fun:Servo_StyleSheet_FromUTF8Bytes
-}
-
-{
-   bug1447137-16
-   Memcheck:Cond
-   fun:*selectors*parser*SelectorList*Impl*parse*
-   fun:Servo_StyleSheet_FromUTF8Bytes
-   fun:*mozilla*ServoStyleSheet*ParseSheet*
-   fun:*mozilla*css*Loader*DoParseSheetServo*
 }
 
 ##########################################
 # Suppressions rooted at *style*properties*shorthands*
 
 {
    bug1447137-17
    Memcheck:Cond