Bug 1530588 - Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState. r=kip
authorDaosheng Mu <daoshengmu@gmail.com>
Wed, 27 Feb 2019 00:02:06 +0000
changeset 519157 bb361d09129fac430e1a70d0108a7e15893e6b53
parent 519156 17d59b664c0fca195a1169c7a62f995480617d0a
child 519158 74f246913bb514e59b39cd7a1a2ce97bc2db8eff
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskip
bugs1530588
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530588 - Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState. r=kip MozReview-Commit-ID: Emmkw2CazxB Differential Revision: https://phabricator.services.mozilla.com/D21169
gfx/vr/gfxVRExternal.cpp
--- a/gfx/vr/gfxVRExternal.cpp
+++ b/gfx/vr/gfxVRExternal.cpp
@@ -891,16 +891,12 @@ void VRSystemManagerExternal::PushState(
     WaitForMutex lock(mMutex);
     status = lock.GetStatus();
 #  endif  // defined(XP_WIN)
     if (status) {
       mExternalShmem->geckoGenerationA++;
       memcpy((void*)&(mExternalShmem->geckoState), (void*)aBrowserState,
              sizeof(VRBrowserState));
       mExternalShmem->geckoGenerationB++;
-      mExternalShmem->geckoGenerationA++;
-      memcpy((void*)&(mExternalShmem->geckoState), (void*)aBrowserState,
-             sizeof(VRBrowserState));
-      mExternalShmem->geckoGenerationB++;
     }
 #endif    // defined(MOZ_WIDGET_ANDROID)
   }
 }