Bug 1466242 Look for Sprintf.h instead of Assertions.h in the symbolstore test r=glandium
authorTom Ritter <tom@mozilla.com>
Tue, 05 Jun 2018 10:44:03 -0500
changeset 476119 badcfe94e6a79792ff5bb6ed96436977d0da888c
parent 476118 1eee411e9a96bacd910bc15e3fd159a6385fa6dd
child 476120 295900f1ae690684391457c12a8b32c20458442a
push id9374
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:43:20 +0000
treeherdermozilla-beta@160e085dfb0b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1466242
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466242 Look for Sprintf.h instead of Assertions.h in the symbolstore test r=glandium It turns out sometimes (in the LTO+CFI case at least) Assertions.h will not be present in the opt build, presumably because it was optimized out. MozReview-Commit-ID: GB3GIoSdIUK
toolkit/crashreporter/tools/unit-symbolstore.py
--- a/toolkit/crashreporter/tools/unit-symbolstore.py
+++ b/toolkit/crashreporter/tools/unit-symbolstore.py
@@ -530,15 +530,15 @@ class TestFunctional(HelperMixin, unitte
             if not os.path.isdir(mozpath.join(self.topsrcdir, '.hg')):
                 return
             for line in match_lines:
                 filename = line.split(None, 2)[2]
                 self.assertEqual('hg:', filename[:3])
         # Check that nsBrowserApp.cpp is listed as a FILE line, and that
         # it was properly mapped to the source repo.
         check_hg_path(file_lines, 'nsBrowserApp.cpp')
-        # Also check Assertions.h to verify that files from dist/include
+        # Also check Sprintf.h to verify that files from dist/include
         # are properly mapped.
-        check_hg_path(file_lines, 'mfbt/Assertions.h')
+        check_hg_path(file_lines, 'mfbt/Sprintf.h')
 
 
 if __name__ == '__main__':
     mozunit.main()