Bug 1352664 - temporarily increase threshold for per-compartment timing checks to avoid intermittent orange, r=Yoric
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Wed, 19 Apr 2017 14:14:28 +0100
changeset 402412 ba94dfa2c7f3
parent 402411 f91f21db5c8e
child 402413 0972898afcd2
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersYoric
bugs1352664
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1352664 - temporarily increase threshold for per-compartment timing checks to avoid intermittent orange, r=Yoric This is a temporary workaround to avoid the intermittent orange. We still need to track down what the underlying cause of the difference in timings between compartments and processes really is. MozReview-Commit-ID: GmT67UDuTqN
toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
--- a/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
+++ b/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
@@ -160,17 +160,17 @@ function monotinicity_tester(source, tes
     for (let item of snapshot.componentsData) {
       for (let [probe, k] of [
         ["jank", "totalUserTime"],
         ["jank", "totalSystemTime"],
         ["cpow", "totalCPOWTime"]
       ]) {
         // Note that we cannot expect components data to be always smaller
         // than process data, as `getrusage` & co are not monotonic.
-        SilentAssert.leq(item[probe][k], 3 * snapshot.processData[probe][k],
+        SilentAssert.leq(item[probe][k], 6 * snapshot.processData[probe][k],
           `Sanity check (${name}): ${k} of component is not impossibly larger than that of process`);
       }
 
       let isCorrectPid = (item.processId == pid && !item.isChildProcess)
         || (item.processId != pid && item.isChildProcess);
       SilentAssert.ok(isCorrectPid, `Pid check (${name}): the item comes from the right process`);
 
       let key = item.groupId;