Bug 864000 - Document nsSVGTextFrame2::mPositioningDirty better. (DONTBUILD) rs=jwatt
authorCameron McCormack <cam@mcc.id.au>
Fri, 26 Apr 2013 09:05:34 +1000
changeset 140945 ba72022a3db0bd207b251392e378273e38c32b51
parent 140944 0a7e98a3c3ebbdd7f11770f24a3a71bae9199918
child 140946 883df548b01486c13fb43afd5adb965dd4376ef2
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwatt
bugs864000
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 864000 - Document nsSVGTextFrame2::mPositioningDirty better. (DONTBUILD) rs=jwatt
layout/svg/nsSVGTextFrame2.h
--- a/layout/svg/nsSVGTextFrame2.h
+++ b/layout/svg/nsSVGTextFrame2.h
@@ -623,14 +623,21 @@ private:
   /**
    * The flag to pass to GetCanvasTM from UpdateFontSizeScaleFactor.  This is
    * normally FOR_OUTERSVG_TM, but while painting or hit testing a pattern or
    * marker, we set it to FOR_PAINTING or FOR_HIT_TESTING appropriately.
    */
   uint32_t mGetCanvasTMForFlag;
 
   /**
-   * Whether something has changed to invalidate the values in mPositions.
+   * The NS_FRAME_IS_DIRTY and NS_FRAME_HAS_DIRTY_CHILDREN bits indicate
+   * that our anonymous block child needs to be reflowed, and that mPositions
+   * will likely need to be updated as a consequence. These are set, for
+   * example, when the font-family changes. Sometimes we only need to
+   * update mPositions though. For example if the x/y attributes change.
+   * mPositioningDirty is used to indicate this latter "things are dirty" case
+   * to allow us to avoid reflowing the anonymous block when it is not
+   * necessary.
    */
   bool mPositioningDirty;
 };
 
 #endif