Bug 1507924 - Remove codemirror/old-debugger.css and related assets; r=jdescottes
authorFlorens Verschelde <florens@fvsch.com>
Wed, 28 Nov 2018 14:21:11 +0000
changeset 504972 ba69286f9c33df034a2a471859acaf9cd12d9380
parent 504971 848f4907fb07bec6d27700edd556d7e68e271eae
child 504973 d6229a4bce1ad2b785a8f6da57bdbf49906bc123
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1507924
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507924 - Remove codemirror/old-debugger.css and related assets; r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D12174
devtools/client/jar.mn
devtools/client/sourceeditor/codemirror/cmiframe.html
devtools/client/sourceeditor/codemirror/old-debugger.css
devtools/client/themes/canvasdebugger.css
devtools/client/themes/images/breakpoint.svg
devtools/client/themes/images/canvasdebugger-step-in.svg
devtools/client/themes/images/canvasdebugger-step-out.svg
devtools/client/themes/images/canvasdebugger-step-over.svg
devtools/client/themes/images/debugger-step-in.svg
devtools/client/themes/images/debugger-step-out.svg
devtools/client/themes/images/debugger-step-over.svg
devtools/client/themes/images/editor-error.png
--- a/devtools/client/jar.mn
+++ b/devtools/client/jar.mn
@@ -17,17 +17,16 @@ devtools.jar:
     content/inspector/markup/markup.xhtml (inspector/markup/markup.xhtml)
     content/sourceeditor/codemirror/addon/dialog/dialog.css (sourceeditor/codemirror/addon/dialog/dialog.css)
     content/sourceeditor/codemirror/addon/hint/show-hint.js (sourceeditor/codemirror/addon/hint/show-hint.js)
     content/sourceeditor/codemirror/addon/tern/tern.js (sourceeditor/codemirror/addon/tern/tern.js)
     content/sourceeditor/codemirror/codemirror.bundle.js (sourceeditor/codemirror/codemirror.bundle.js)
     content/sourceeditor/codemirror/lib/codemirror.css (sourceeditor/codemirror/lib/codemirror.css)
     content/sourceeditor/codemirror/mozilla.css (sourceeditor/codemirror/mozilla.css)
     content/sourceeditor/codemirror/cmiframe.html (sourceeditor/codemirror/cmiframe.html)
-    content/sourceeditor/codemirror/old-debugger.css (sourceeditor/codemirror/old-debugger.css)
     content/debugger/new/index.html (debugger/new/index.html)
     content/shadereditor/index.xul (shadereditor/index.xul)
     content/canvasdebugger/index.xul (canvasdebugger/index.xul)
     content/canvasdebugger/canvasdebugger.js (canvasdebugger/canvasdebugger.js)
     content/canvasdebugger/snapshotslist.js (canvasdebugger/snapshotslist.js)
     content/canvasdebugger/callslist.js (canvasdebugger/callslist.js)
     content/webaudioeditor/index.xul (webaudioeditor/index.xul)
     content/webaudioeditor/includes.js (webaudioeditor/includes.js)
@@ -134,18 +133,16 @@ devtools.jar:
     skin/images/command-frames.svg (themes/images/command-frames.svg)
     skin/images/command-console.svg (themes/images/command-console.svg)
     skin/images/command-eyedropper.svg (themes/images/command-eyedropper.svg)
     skin/images/command-rulers.svg (themes/images/command-rulers.svg)
     skin/images/command-measure.svg (themes/images/command-measure.svg)
     skin/images/command-noautohide.svg (themes/images/command-noautohide.svg)
     skin/images/command-chevron.svg (themes/images/command-chevron.svg)
     skin/markup.css (themes/markup.css)
-    skin/images/editor-error.png (themes/images/editor-error.png)
-    skin/images/breakpoint.svg (themes/images/breakpoint.svg)
     skin/webconsole.css (themes/webconsole.css)
     skin/images/webconsole/error.svg (themes/images/webconsole/error.svg)
     skin/images/webconsole/info.svg (themes/images/webconsole/info.svg)
     skin/images/webconsole/input.svg (themes/images/webconsole/input.svg)
     skin/images/webconsole/return.svg (themes/images/webconsole/return.svg)
     skin/images/webconsole/jump.svg (themes/images/webconsole/jump.svg)
     skin/images/breadcrumbs-scrollbutton.svg (themes/images/breadcrumbs-scrollbutton.svg)
     skin/animation.css (themes/animation.css)
@@ -171,19 +168,19 @@ devtools.jar:
     skin/images/item-arrow-ltr.svg (themes/images/item-arrow-ltr.svg)
     skin/images/dropmarker.svg (themes/images/dropmarker.svg)
     skin/boxmodel.css (themes/boxmodel.css)
     skin/images/geometry-editor.svg (themes/images/geometry-editor.svg)
     skin/images/more.svg (themes/images/more.svg)
     skin/images/pause.svg (themes/images/pause.svg)
     skin/images/play.svg (themes/images/play.svg)
     skin/images/rewind.svg (themes/images/rewind.svg)
-    skin/images/debugger-step-in.svg (themes/images/debugger-step-in.svg)
-    skin/images/debugger-step-out.svg (themes/images/debugger-step-out.svg)
-    skin/images/debugger-step-over.svg (themes/images/debugger-step-over.svg)
+    skin/images/canvasdebugger-step-in.svg (themes/images/canvasdebugger-step-in.svg)
+    skin/images/canvasdebugger-step-out.svg (themes/images/canvasdebugger-step-out.svg)
+    skin/images/canvasdebugger-step-over.svg (themes/images/canvasdebugger-step-over.svg)
     skin/images/dock-bottom.svg (themes/images/dock-bottom.svg)
     skin/images/dock-side-left.svg (themes/images/dock-side-left.svg)
     skin/images/dock-side-right.svg (themes/images/dock-side-right.svg)
     skin/images/dock-undock.svg (themes/images/dock-undock.svg)
     skin/floating-scrollbars-responsive-design.css (themes/floating-scrollbars-responsive-design.css)
     skin/badge.css (themes/badge.css)
     skin/inspector.css (themes/inspector.css)
     skin/images/profiler-stopwatch.svg (themes/images/profiler-stopwatch.svg)
--- a/devtools/client/sourceeditor/codemirror/cmiframe.html
+++ b/devtools/client/sourceeditor/codemirror/cmiframe.html
@@ -4,12 +4,11 @@
   <style id="cmBaseStyle">
     html, body { height: 100%; }
     body { margin: 0; overflow: hidden; }
     .CodeMirror { width: 100% !important; line-height: 1.25 !important; }
   </style>
   <link rel='stylesheet' href="chrome://devtools/content/sourceeditor/codemirror/lib/codemirror.css">
   <link rel='stylesheet' href="chrome://devtools/content/sourceeditor/codemirror/addon/dialog/dialog.css">
   <link rel='stylesheet' href="chrome://devtools/content/sourceeditor/codemirror/mozilla.css">
-  <link rel='stylesheet' href="chrome://devtools/content/sourceeditor/codemirror/old-debugger.css">
 </head>
 <body class='theme-body devtools-monospace'></body>
 </html>
deleted file mode 100644
--- a/devtools/client/sourceeditor/codemirror/old-debugger.css
+++ /dev/null
@@ -1,21 +0,0 @@
-:root {
-  --breakpoint-background: url("chrome://devtools/skin/images/breakpoint.svg#light");
-  --breakpoint-conditional-background: url("chrome://devtools/skin/images/breakpoint.svg#light-conditional");
-}
-
-.theme-dark:root {
-  --breakpoint-background: url("chrome://devtools/skin/images/breakpoint.svg#dark");
-  --breakpoint-conditional-background: url("chrome://devtools/skin/images/breakpoint.svg#dark-conditional");
-}
-
-.breakpoint .CodeMirror-linenumber:before {
-  background-image: var(--breakpoint-background) !important;
-}
-
-.conditional .CodeMirror-linenumber:before {
-  background-image: var(--breakpoint-conditional-background) !important;
-}
-
-.CodeMirror .error {
-  background-image: url("chrome://devtools/skin/images/editor-error.png");
-}
--- a/devtools/client/themes/canvasdebugger.css
+++ b/devtools/client/themes/canvasdebugger.css
@@ -112,25 +112,25 @@
 }
 
 /* Debugging pane controls */
 #resume {
   list-style-image: url(images/play.svg);
 }
 
 #step-over {
-  list-style-image: url(images/debugger-step-over.svg);
+  list-style-image: url(images/canvasdebugger-step-over.svg);
 }
 
 #step-in {
-  list-style-image: url(images/debugger-step-in.svg);
+  list-style-image: url(images/canvasdebugger-step-in.svg);
 }
 
 #step-out {
-  list-style-image: url(images/debugger-step-out.svg);
+  list-style-image: url(images/canvasdebugger-step-out.svg);
 }
 
 #debugging-toolbar-sizer-button {
   /* This button's only purpose in life is to make the
      container .devtools-toolbar have the right height. */
   visibility: hidden;
   min-width: 1px;
 }
deleted file mode 100644
--- a/devtools/client/themes/images/breakpoint.svg
+++ /dev/null
@@ -1,45 +0,0 @@
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="33" height="12" viewBox="0 0 33 12">
-  <defs>
-    <style>
-      use:not(:target) {
-        display: none;
-      }
-      #light {
-        fill: #46afe3;
-      }
-      #light-hover {
-        fill: #9aa6b3;
-      }
-      #light-active {
-        fill: #2cbb0f;
-      }
-      #light-conditional {
-        fill: #d97e00;
-      }
-      #dark {
-        fill: #46afe3;
-      }
-      #dark-hover {
-        fill: #3d454d;
-      }
-      #dark-active {
-        fill: #70bf53;
-      }
-      #dark-conditional {
-        fill: #d89b28;
-      }
-    </style>
-    <path id="base-path" d="M27.1,0H1C0.4,0,0,0.4,0,1v10c0,0.6,0.4,1,1,1h26.1 c0.6,0,1.2-0.3,1.5-0.7L33,6l-4.4-5.3C28.2,0.3,27.7,0,27.1,0z"/>
-  </defs>
-  <use xlink:href="#base-path" id="light"/>
-  <use xlink:href="#base-path" id="light-hover"/>
-  <use xlink:href="#base-path" id="light-active"/>
-  <use xlink:href="#base-path" id="light-conditional"/>
-  <use xlink:href="#base-path" id="dark"/>
-  <use xlink:href="#base-path" id="dark-hover"/>
-  <use xlink:href="#base-path" id="dark-active"/>
-  <use xlink:href="#base-path" id="dark-conditional"/>
-</svg>
rename from devtools/client/themes/images/debugger-step-in.svg
rename to devtools/client/themes/images/canvasdebugger-step-in.svg
rename from devtools/client/themes/images/debugger-step-out.svg
rename to devtools/client/themes/images/canvasdebugger-step-out.svg
rename from devtools/client/themes/images/debugger-step-over.svg
rename to devtools/client/themes/images/canvasdebugger-step-over.svg
deleted file mode 100644
index 5a098e90b785be63b12860cd914380da3645e8d7..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001