Bug 865234 - Part 6: Round up the |when| argument AudioBufferSouceNode.start; r=roc
authorEhsan Akhgari <ehsan@mozilla.com>
Mon, 29 Apr 2013 19:22:49 -0400
changeset 141403 ba325c53d7736f162445d0ac761c6dee3f6d749a
parent 141402 b28a0e8f357ff4aa7515489d592406e02bf9eaa2
child 141404 7ed8524e54f5c3d740780d52cc73510ae6e80337
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs865234
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 865234 - Part 6: Round up the |when| argument AudioBufferSouceNode.start; r=roc This change is made in order to increase compatibility of the implementation with what WebKit does. This helps us in order to be able to compare our results more closely to WebKit's.
content/media/AudioNodeStream.cpp
--- a/content/media/AudioNodeStream.cpp
+++ b/content/media/AudioNodeStream.cpp
@@ -51,17 +51,17 @@ AudioNodeStream::SetStreamTimeParameter(
 
 void
 AudioNodeStream::SetStreamTimeParameterImpl(uint32_t aIndex, MediaStream* aRelativeToStream,
                                             double aStreamTime)
 {
   StreamTime streamTime = std::max<MediaTime>(0, SecondsToMediaTime(aStreamTime));
   GraphTime graphTime = aRelativeToStream->StreamTimeToGraphTime(streamTime);
   StreamTime thisStreamTime = GraphTimeToStreamTimeOptimistic(graphTime);
-  TrackTicks ticks = TimeToTicksRoundDown(IdealAudioRate(), thisStreamTime);
+  TrackTicks ticks = TimeToTicksRoundUp(IdealAudioRate(), thisStreamTime);
   mEngine->SetStreamTimeParameter(aIndex, ticks);
 }
 
 void
 AudioNodeStream::SetDoubleParameter(uint32_t aIndex, double aValue)
 {
   class Message : public ControlMessage {
   public: