Bug 1272409 - Part 5: Update test meta. r=dholbert
authorBoris Chiou <boris.chiou@gmail.com>
Fri, 26 Apr 2019 20:29:20 +0000
changeset 530411 b86894409b1b4481691a82b33f3107254511591c
parent 530410 87c7a189cbe0d917f6579f796e43a8e5c29e7681
child 530412 0e3eef30f66b0c5fe6886f46011f7e7210cbfab2
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1272409
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1272409 - Part 5: Update test meta. r=dholbert In idlharness.window.js, ResizeObservation is not an public interface in the current spec, so the test should be updated. In eventloop.html, unfortunately, there are two issues: 1. The test framework will be timeout if there is any `assert_equals()` failed. We should rewrite it. 2. Actually, we only have one failure in this test file: `assert_equals(helper.rafCount, 1, "new loop");` in test0. We fire this event in the next Tick(), but we call the callback of `requestAnimationFrame()` after several Tick()s, so `helper.rafCount` is still 0 in this case. This may be a bug of the test because using `requestAnimationFrame()` cannot reflect the next event loop, or our scheduling of ResizeObserver is not correct. Note: this assert_equal() was added by Google, not by Fariskhi. Differential Revision: https://phabricator.services.mozilla.com/D27619
testing/web-platform/meta/resize-observer/__dir__.ini
testing/web-platform/meta/resize-observer/eventloop.html.ini
testing/web-platform/meta/resize-observer/idlharness.window.js.ini
testing/web-platform/meta/resize-observer/notify.html.ini
testing/web-platform/meta/resize-observer/observe.html.ini
testing/web-platform/meta/resize-observer/svg.html.ini
testing/web-platform/tests/resize-observer/META.yml
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/meta/resize-observer/__dir__.ini
@@ -0,0 +1,1 @@
+prefs: [layout.css.resizeobserver.enabled:true]
--- a/testing/web-platform/meta/resize-observer/eventloop.html.ini
+++ b/testing/web-platform/meta/resize-observer/eventloop.html.ini
@@ -1,4 +1,7 @@
 [eventloop.html]
-  [ResizeObserver implemented]
+  disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1545309
+  [guard]
+    expected: NOTRUN
+  [test0: multiple notifications inside same event loop]
     expected: FAIL
 
--- a/testing/web-platform/meta/resize-observer/idlharness.window.js.ini
+++ b/testing/web-platform/meta/resize-observer/idlharness.window.js.ini
@@ -1,156 +1,69 @@
 [idlharness.window.html]
-  [ResizeObserver interface: operation unobserve(Element)]
-    expected: FAIL
-
-  [ResizeObserver interface: observer must inherit property "observe(Element)" with the proper type]
-    expected: FAIL
-
   [ResizeObservation interface object length]
     expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface object name]
     expected: FAIL
-
-  [ResizeObserver interface: observer must inherit property "disconnect()" with the proper type]
-    expected: FAIL
-
-  [ResizeObserver interface: existence and properties of interface prototype object]
-    expected: FAIL
-
-  [ResizeObserverEntry must be primary interface of entry]
-    expected: FAIL
-
-  [ResizeObserver interface: operation observe(Element)]
-    expected: FAIL
-
-  [Stringification of entry]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: operation isActive()]
     expected: FAIL
-
-  [ResizeObserverEntry interface object length]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: attribute target]
     expected: FAIL
-
-  [ResizeObserverEntry interface: attribute target]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: existence and properties of interface prototype object's @@unscopables property]
     expected: FAIL
-
-  [ResizeObserverEntry interface: entry must inherit property "target" with the proper type]
-    expected: FAIL
-
-  [ResizeObserverEntry interface: entry must inherit property "contentRect" with the proper type]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: existence and properties of interface prototype object's "constructor" property]
     expected: FAIL
-
-  [ResizeObserver interface object length]
-    expected: FAIL
-
-  [ResizeObserver interface object name]
-    expected: FAIL
-
-  [ResizeObserver interface: operation disconnect()]
-    expected: FAIL
-
-  [ResizeObserver interface: existence and properties of interface prototype object's @@unscopables property]
-    expected: FAIL
-
-  [ResizeObserver interface: existence and properties of interface prototype object's "constructor" property]
-    expected: FAIL
-
-  [Stringification of observer]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: existence and properties of interface prototype object]
     expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: attribute broadcastWidth]
     expected: FAIL
-
-  [ResizeObserver interface: calling unobserve(Element) on observer with too few arguments must throw TypeError]
-    expected: FAIL
-
-  [Test IDL implementation of ResizeObserver]
-    expected: FAIL
-
-  [ResizeObserver must be primary interface of observer]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: existence and properties of interface object]
     expected: FAIL
-
-  [ResizeObserverEntry interface: existence and properties of interface prototype object]
-    expected: FAIL
-
-  [ResizeObserverEntry interface: existence and properties of interface prototype object's "constructor" property]
-    expected: FAIL
-
-  [ResizeObserverEntry interface: existence and properties of interface prototype object's @@unscopables property]
-    expected: FAIL
-
-  [ResizeObserverEntry interface: existence and properties of interface object]
-    expected: FAIL
-
-  [ResizeObserverEntry interface object name]
-    expected: FAIL
-
-  [ResizeObserver interface: existence and properties of interface object]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: attribute broadcastHeight]
     expected: FAIL
-
-  [ResizeObserver interface: observer must inherit property "unobserve(Element)" with the proper type]
-    expected: FAIL
-
-  [ResizeObserver interface: calling observe(Element) on observer with too few arguments must throw TypeError]
-    expected: FAIL
-
-  [ResizeObserverEntry interface: attribute contentRect]
-    expected: FAIL
-
-  [idl_test setup]
-    expected: FAIL
-
-  [ResizeObserver interface: calling observe(Element, ResizeObserverOptions) on observer with too few arguments must throw TypeError]
-    expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObserverEntry interface: attribute borderBoxSize]
     expected: FAIL
 
   [ResizeObserverSize interface: existence and properties of interface prototype object's @@unscopables property]
     expected: FAIL
 
   [ResizeObserverSize interface object length]
     expected: FAIL
 
-  [ResizeObserver interface: observer must inherit property "observe(Element, ResizeObserverOptions)" with the proper type]
-    expected: FAIL
-
   [ResizeObservation interface: attribute lastReportedSize]
     expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObservation interface: attribute observedBox]
     expected: FAIL
+    bug: https://github.com/w3c/csswg-drafts/issues/3839
 
   [ResizeObserverSize interface: attribute inlineSize]
     expected: FAIL
 
-  [ResizeObserver interface: operation observe(Element, ResizeObserverOptions)]
-    expected: FAIL
-
   [ResizeObserverSize interface object name]
     expected: FAIL
 
   [ResizeObserverSize interface: existence and properties of interface prototype object]
     expected: FAIL
 
   [ResizeObserverEntry interface: entry must inherit property "contentBoxSize" with the proper type]
     expected: FAIL
@@ -164,9 +77,8 @@
   [ResizeObserverEntry interface: entry must inherit property "borderBoxSize" with the proper type]
     expected: FAIL
 
   [ResizeObserverSize interface: existence and properties of interface object]
     expected: FAIL
 
   [ResizeObserverSize interface: existence and properties of interface prototype object's "constructor" property]
     expected: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/resize-observer/notify.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[notify.html]
-  expected: ERROR
-  [ResizeObserver implemented]
-    expected: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/resize-observer/observe.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[observe.html]
-  [ResizeObserver implemented]
-    expected: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/resize-observer/svg.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[svg.html]
-  [ResizeObserver implemented]
-    expected: FAIL
-
--- a/testing/web-platform/tests/resize-observer/META.yml
+++ b/testing/web-platform/tests/resize-observer/META.yml
@@ -1,4 +1,4 @@
-spec: https://wicg.github.io/ResizeObserver/
+spec: https://drafts.csswg.org/resize-observer/
 suggested_reviewers:
   - atotic
   - dholbert