Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 22 Aug 2018 08:58:08 +0900
changeset 487861 b7f4a1596d18d093e8f25bc8947a005d75ee2e7f
parent 487860 d91e84fc8bb6ed639e895fc5f691915a6ea1bced
child 487862 854353ad4d264ea1d0afe0394512cfc28f8ded03
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1485210
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn When valgrind prints out backtraces, it prints raw addresses and symbol names, but that doesn't help find the exact code that caused the errors, because we don't know where the libraries are loaded. With --sym-offsets=yes, it adds the offset from the symbol, which allows to find the relevant code in the binary.
build/valgrind/mach_commands.py
--- a/build/valgrind/mach_commands.py
+++ b/build/valgrind/mach_commands.py
@@ -109,16 +109,17 @@ class MachCommands(MachCommandBase):
             kp_kwargs = {'processOutputLine': [outputHandler]}
 
             valgrind = 'valgrind'
             if not os.path.exists(valgrind):
                 valgrind = findInPath(valgrind)
 
             valgrind_args = [
                 valgrind,
+                '--sym-offsets=yes',
                 '--smc-check=all-non-file',
                 '--vex-iropt-register-updates=allregs-at-mem-access',
                 '--gen-suppressions=all',
                 '--num-callers=36',
                 '--leak-check=full',
                 '--show-possibly-lost=no',
                 '--track-origins=yes',
                 '--trace-children=yes',