Bug 1388396: Use IconRequestBuilder.forActivityStream in AS UI. r=sebastian
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 11 Sep 2017 17:27:22 -0700
changeset 430242 b79ec53305633fe444abfe4b0d7d64de276309bb
parent 430241 a5f78f2e5bfd84b220a6b886f0feb48c478f9d17
child 430243 bca0b077f039e78fb8fdf6831adfa2d35ef57c88
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1388396
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1388396: Use IconRequestBuilder.forActivityStream in AS UI. r=sebastian MozReview-Commit-ID: jLVtXk0hJZ
mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/stream/StreamOverridablePageIconLayout.java
mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/topsites/TopSitesCard.java
--- a/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/stream/StreamOverridablePageIconLayout.java
+++ b/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/stream/StreamOverridablePageIconLayout.java
@@ -73,16 +73,17 @@ public class StreamOverridablePageIconLa
                     .centerCrop()
                     .into(imageView);
         } else {
             setUIMode(UIMode.FAVICON_IMAGE);
 
             ongoingFaviconLoad = Icons.with(getContext())
                     .pageUrl(pageURL)
                     .skipNetwork()
+                    .forActivityStream()
                     .build()
                     .execute(this);
         }
     }
 
     @Override
     public void onIconResponse(final IconResponse response) {
         faviconView.updateImage(response);
--- a/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/topsites/TopSitesCard.java
+++ b/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/topsites/TopSitesCard.java
@@ -101,16 +101,17 @@ import java.util.concurrent.Future;
             // Sometimes we get top sites without or with an empty URL - even though we do not allow
             // this anywhere in our UI. However with 'sync' we are not in full control of the data.
             // Whenever the URL is empty or null we just clear a potentially previously set icon.
             faviconView.clearImage();
         } else {
             ongoingIconLoad = Icons.with(itemView.getContext())
                     .pageUrl(topSite.getUrl())
                     .skipNetwork()
+                    .forActivityStream()
                     .build()
                     .execute(this);
         }
 
         final Drawable pinDrawable;
         if (topSite.isPinned()) {
             pinDrawable = DrawableUtil.tintDrawable(itemView.getContext(), R.drawable.as_pin, Color.WHITE);
         } else {