Bug 1387399 - Followup: Fix Windows static analysis bustage. r+a=bustage on a CLOSED TREE
☠☠ backed out by ec3dd3ee2ae4 ☠ ☠
authorBas Schouten <bschouten@mozilla.com>
Thu, 19 Apr 2018 17:02:09 +0200
changeset 468088 b78a225fa8c9155c5c97813c0b0e52d2c07cdf2a
parent 468087 15bc0efa7203b08b7681241e8e7a67848064341e
child 468089 33032a57c49f3fdf77f3e96edbfbb046e443766d
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1387399
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1387399 - Followup: Fix Windows static analysis bustage. r+a=bustage on a CLOSED TREE MozReview-Commit-ID: AUdLD5Aiplc
gfx/src/nsRect.h
--- a/gfx/src/nsRect.h
+++ b/gfx/src/nsRect.h
@@ -120,17 +120,17 @@ struct nsRect :
   {
     return Super::Union(aRect);
   }
   void UnionRect(const nsRect& aRect1, const nsRect& aRect2)
   {
     *this = aRect1.Union(aRect2);
   }
 
-#ifdef _MSC_VER
+#if defined(_MSC_VER) && !defined(__clang__)
   // Only MSVC supports inlining intrinsics for archs you're not compiling for.
   MOZ_MUST_USE nsRect Intersect(const nsRect& aRect) const
   {
     nsRect result;
     if (mozilla::gfx::Factory::HasSSE4()) {
       __m128i rect1 = _mm_loadu_si128((__m128i*)&aRect); // x1, y1, w1, h1
       __m128i rect2 = _mm_loadu_si128((__m128i*)this); // x2, y2, w2, h2