Bug 1130203 - Remove excess LinearLayout from ShareOverlay. r=mhaigh a=sylvestre
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 18 Mar 2015 16:28:02 -0700
changeset 258345 b731c0df23aa
parent 258344 8691a7ac4c95
child 258346 1c2ce96f9359
push id4648
push usermichael.l.comella@gmail.com
push date2015-04-08 16:26 +0000
treeherdermozilla-beta@e399294c9df3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh, sylvestre
bugs1130203
milestone38.0
Bug 1130203 - Remove excess LinearLayout from ShareOverlay. r=mhaigh a=sylvestre
mobile/android/base/resources/layout/overlay_share_dialog.xml
--- a/mobile/android/base/resources/layout/overlay_share_dialog.xml
+++ b/mobile/android/base/resources/layout/overlay_share_dialog.xml
@@ -31,43 +31,37 @@
             android:layout_marginBottom="8dp"/>
 
         <!-- Subtitle (url) -->
         <TextView
             android:id="@+id/subtitle"
             style="@style/ShareOverlayTitle"
             android:textAppearance="@style/ShareOverlayTextAppearance.Header.Subtitle"
             android:layout_width="match_parent"
-            android:layout_height="wrap_content"/>
+            android:layout_height="wrap_content"
+            android:layout_marginBottom="20dp"/>
 
         <!-- TODO: Add back drop shadow? -->
         <!-- Buttons -->
-        <LinearLayout
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:layout_marginTop="20dp"
-            android:orientation="vertical">
-
-            <!-- "Send to Firefox Sync" -->
-            <org.mozilla.gecko.overlays.ui.SendTabList
-                style="@style/ShareOverlayButton"
-                android:id="@+id/overlay_send_tab_btn"
-                android:padding="0dp"
-                android:divider="@null"/>
+        <!-- "Send to Firefox Sync" -->
+        <org.mozilla.gecko.overlays.ui.SendTabList
+            style="@style/ShareOverlayButton"
+            android:id="@+id/overlay_send_tab_btn"
+            android:padding="0dp"
+            android:divider="@null"/>
 
-            <!-- "Add to reading list" -->
-            <org.mozilla.gecko.overlays.ui.OverlayDialogButton
-                style="@style/ShareOverlayButton.Text.Container"
-                android:id="@+id/overlay_share_reading_list_btn"
-                android:background="@drawable/overlay_share_button_background"
-                android:enabled="false"/>
+        <!-- "Add to reading list" -->
+        <org.mozilla.gecko.overlays.ui.OverlayDialogButton
+            style="@style/ShareOverlayButton.Text.Container"
+            android:id="@+id/overlay_share_reading_list_btn"
+            android:background="@drawable/overlay_share_button_background"
+            android:enabled="false"/>
 
-            <!-- "Add bookmark" -->
-            <org.mozilla.gecko.overlays.ui.OverlayDialogButton
-                style="@style/ShareOverlayButton.Text.Container"
-                android:id="@+id/overlay_share_bookmark_btn"
-                android:background="@drawable/overlay_share_button_background"
-                android:enabled="false"/>
+        <!-- "Add bookmark" -->
+        <org.mozilla.gecko.overlays.ui.OverlayDialogButton
+            style="@style/ShareOverlayButton.Text.Container"
+            android:id="@+id/overlay_share_bookmark_btn"
+            android:background="@drawable/overlay_share_button_background"
+            android:enabled="false"/>
 
-        </LinearLayout>
     </LinearLayout>
 
 </FrameLayout>