Bug 1399245 - Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. r=Gijs, a=lizzard FIREFOX_56b13_RELBRANCH
authorMichael Kelly <mkelly@mozilla.com>
Tue, 12 Sep 2017 13:27:12 -0700
branchFIREFOX_56b13_RELBRANCH
changeset 430798 b6d27f6b9830700c29009f55f1f1a5d39b470d7b
parent 430797 5b3d123eee2431d79cf1065d7564b820992a2a31
child 430799 7ff6b593e6623f6ec9e42344ffe944ba32965395
push id7769
push userryanvm@gmail.com
push dateSat, 16 Sep 2017 20:18:30 +0000
treeherdermozilla-beta@a841920fd8cb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, lizzard
bugs1399245
milestone56.0
Bug 1399245 - Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. r=Gijs, a=lizzard Due to changes in browser styles for Photon, the fix is no longer necessary, and in fact makes the close button look wrong. Without the fix, the close button looks and behaves the same as the tab bar close buttons. MozReview-Commit-ID: 89tCvQAq1OR
browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
--- a/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
+++ b/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
@@ -4,21 +4,8 @@
 
 /* Notification overrides for Heartbeat UI */
 
 notification.heartbeat {
   background-image: linear-gradient(-179deg, #FBFBFB 0%, #EBEBEB 100%) !important;
   border-bottom: 1px solid #C1C1C1 !important;
   height: 40px;
 }
-
-/* In themes/osx/global/notification.css the close icon is inverted because notifications
-   on OSX are usually dark. Heartbeat is light, so override that behaviour. */
-
-notification.heartbeat[type="info"] .close-icon:not(:hover) {
-  -moz-image-region: rect(0, 16px, 16px, 0) !important;
-}
-
-@media (min-resolution: 2dppx) {
-  notification.heartbeat[type="info"] .close-icon:not(:hover) {
-    -moz-image-region: rect(0, 32px, 32px, 0) !important;
-  }
-}