Bug 1396864 - eliminate -Wunused-private-field warning in WebrcMediaCodecVideoCodec; r=jesup
authorNathan Froyd <froydnj@mozilla.com>
Wed, 06 Sep 2017 08:57:09 -0400
changeset 428805 b6ba712ab6eb8801f2df63aeafcb875a4b532538
parent 428804 90f6c47bd74fa56cadb00ed65a80d6d3e3e0427d
child 428806 162f24aa26036252a9e33ba0c71170a193bd22ab
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjesup
bugs1396864
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1396864 - eliminate -Wunused-private-field warning in WebrcMediaCodecVideoCodec; r=jesup The mTimestamp field is unused.
media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.h
--- a/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
@@ -691,18 +691,17 @@ static bool I420toNV12(uint8_t* dstY, ui
                                        dst_stride_uv,
                                        inputImage.width(),
                                        inputImage.height());
   return converted;
 }
 
 // Encoder.
 WebrtcMediaCodecVP8VideoEncoder::WebrtcMediaCodecVP8VideoEncoder()
-  : mTimestamp(0)
-  , mCallback(nullptr)
+  : mCallback(nullptr)
   , mMediaCodecEncoder(nullptr) {
   CSFLogDebug(logTag,  "%s ", __FUNCTION__);
 
   memset(&mEncodedImage, 0, sizeof(mEncodedImage));
 }
 
 bool WebrtcMediaCodecVP8VideoEncoder::ResetInputBuffers() {
   mInputBuffers = mMediaCodecEncoder->GetInputBuffers();
--- a/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.h
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.h
@@ -55,17 +55,16 @@ public:
   virtual int32_t SetRates(uint32_t newBitRate, uint32_t frameRate) override;
 
 private:
   int32_t VerifyAndAllocate(const uint32_t minimumSize);
   bool ResetInputBuffers();
   bool ResetOutputBuffers();
 
   size_t mMaxPayloadSize;
-  uint32_t mTimestamp;
   webrtc::EncodedImage mEncodedImage;
   webrtc::EncodedImageCallback* mCallback;
   uint32_t mFrameWidth;
   uint32_t mFrameHeight;
 
   WebrtcAndroidMediaCodec* mMediaCodecEncoder;
 
   jobjectArray mInputBuffers;