Bug 1545272 - Lessen anti-tracking warning spam; r=baku
authorEhsan Akhgari <ehsan@mozilla.com>
Thu, 18 Apr 2019 12:07:25 +0000
changeset 528888 b6a7a19828ff8c19fd5efeec1ebccccbcb934318
parent 528887 17cce14873205ea418028024254852a6d407a0b1
child 528889 2f8f0e53a7dbb3f6d2259cfb0536a83ff84267ac
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1545272
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545272 - Lessen anti-tracking warning spam; r=baku Differential Revision: https://phabricator.services.mozilla.com/D27974
toolkit/components/antitracking/AntiTrackingCommon.cpp
--- a/toolkit/components/antitracking/AntiTrackingCommon.cpp
+++ b/toolkit/components/antitracking/AntiTrackingCommon.cpp
@@ -392,17 +392,17 @@ bool CheckContentBlockingAllowList(nsIHt
       entry.Set(ContentBlockingAllowListEntry(aChannel, false));
       return false;
     }
   } else {
     nsCOMPtr<nsIHttpChannelInternal> chan = do_QueryInterface(aChannel);
     MOZ_ASSERT(chan);
 
     nsresult rv = chan->GetTopWindowURI(getter_AddRefs(uri));
-    if (NS_WARN_IF(NS_FAILED(rv)) || !uri) {
+    if (NS_FAILED(rv) || !uri) {
       LOG(
           ("Could not check the content blocking allow list because the top "
            "window wasn't accessible"));
       entry.Set(ContentBlockingAllowListEntry(aChannel, false));
       return false;
     }
   }