Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge a=gchang
authorMark Hammond <mhammond@skippinet.com.au>
Tue, 25 Oct 2016 13:47:33 +1100
changeset 356352 b673d9fc515be72448527c0e3efcf25f2521f5e5
parent 356351 c6604f69b1b70996277a948b1fad3c654f542b70
child 356353 531d3f05ebf0dc52d6ff076b8c413010c7ed1240
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskitcambridge, gchang
bugs1312642
milestone51.0a2
Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge a=gchang MozReview-Commit-ID: 4EsnU7LSWDG
toolkit/components/places/PlacesSyncUtils.jsm
--- a/toolkit/components/places/PlacesSyncUtils.jsm
+++ b/toolkit/components/places/PlacesSyncUtils.jsm
@@ -73,17 +73,18 @@ const BookmarkSyncUtils = PlacesSyncUtil
     for (let guid of childGuids) {
       PlacesUtils.SYNC_BOOKMARK_VALIDATORS.guid(guid);
     }
     if (parentGuid == PlacesUtils.bookmarks.rootGuid) {
       // Reordering roots doesn't make sense, but Sync will do this on the
       // first sync.
       return Promise.resolve();
     }
-    return PlacesUtils.bookmarks.reorder(parentGuid, childGuids);
+    return PlacesUtils.bookmarks.reorder(parentGuid, childGuids,
+                                         { source: SOURCE_SYNC });
   }),
 
   /**
    * Removes an item from the database.
    */
   remove: Task.async(function* (guid) {
     return PlacesUtils.bookmarks.remove(guid, {
       source: SOURCE_SYNC,