Bug 1330146. Remove windows-xp and windows-vista as values for -moz-os-version from tests. r=dholbert
authorMike Taylor <miket@mozilla.com>
Wed, 19 Jul 2017 11:44:24 -0500
changeset 418482 b626aca18e669be6957857b06779cd8b3bb8dbb7
parent 418481 f49f30c8fefac983bfbb3452c2f43ea9b2e4c753
child 418483 5ca4811f78368b4f5722dae3801a0a9370e89277
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1330146, 1325503
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1330146. Remove windows-xp and windows-vista as values for -moz-os-version from tests. r=dholbert The functionality was removed in Bug 1325503. The reason these tests didn't start failing is because they just test the parsability of the media feature and its' value, not that it does anything useful. MozReview-Commit-ID: 6a0nlKhUZTQ
layout/style/test/chrome/bug418986-2.js
layout/style/test/test_media_queries.html
--- a/layout/style/test/chrome/bug418986-2.js
+++ b/layout/style/test/chrome/bug418986-2.js
@@ -48,18 +48,16 @@ var suppressed_toggles = [
   "-moz-touch-enabled",
   "-moz-windows-compositor",
   "-moz-windows-default-theme",
   "-moz-windows-glass",
 ];
 
 // Possible values for '-moz-os-version'
 var windows_versions = [
-  "windows-xp",
-  "windows-vista",
   "windows-win7",
   "windows-win8",
   "windows-win10",
 ];
 
 // Possible values for '-moz-windows-theme'
 var windows_themes = [
   "aero",
--- a/layout/style/test/test_media_queries.html
+++ b/layout/style/test/test_media_queries.html
@@ -708,18 +708,16 @@ function run() {
   expression_should_be_parseable("-moz-windows-theme: royale");
   expression_should_be_parseable("-moz-windows-theme: generic");
   expression_should_be_parseable("-moz-windows-theme: zune");
   expression_should_be_parseable("-moz-windows-theme: garbage");
   expression_should_not_be_parseable("-moz-windows-theme: ''");
   expression_should_not_be_parseable("-moz-windows-theme: ");
 
   // os version media queries (currently windows only)
-  expression_should_be_parseable("-moz-os-version: windows-xp");
-  expression_should_be_parseable("-moz-os-version: windows-vista");
   expression_should_be_parseable("-moz-os-version: windows-win7");
   expression_should_be_parseable("-moz-os-version: windows-win8");
   expression_should_be_parseable("-moz-os-version: windows-win10");
   expression_should_not_be_parseable("-moz-os-version: ");
 
   // OpenType SVG media features
   query_should_be_parseable("(-moz-is-glyph)");
   query_should_not_be_parseable("not (-moz-is-glyph)");