Bug 1239096 - Improve English is artifacts.py comments. r=me
authorBryce Van Dyk <bvandyk@mozilla.com>
Wed, 13 Jan 2016 10:46:28 +1300
changeset 314790 b5fd127bc828f812fd3beca3fba5ec5fe8d4b04a
parent 314789 4b34c9d1a31a0f3af5f130315acd0585755b5aaf
child 314791 d6a85731d2aa518779451ebf8583815151565c56
push id5703
push userraliiev@mozilla.com
push dateMon, 07 Mar 2016 14:18:41 +0000
treeherdermozilla-beta@31e373ad5b5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1239096
milestone46.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1239096 - Improve English is artifacts.py comments. r=me
python/mozbuild/mozbuild/artifacts.py
--- a/python/mozbuild/mozbuild/artifacts.py
+++ b/python/mozbuild/mozbuild/artifacts.py
@@ -413,25 +413,25 @@ class PushHeadCache(CacheManager):
                 '--template', '{node}\n',
                 '-r', 'last(pushhead("{tree}") and ::"{parent}", {num})'.format(
                     tree=tree, parent=parent, num=NUM_PUSHHEADS_TO_QUERY_PER_PARENT)])
             # Filter blank lines.
             pushheads = [ pushhead for pushhead in pushheads.strip().split('\n') if pushhead ]
             if pushheads:
                 return pushheads
         except subprocess.CalledProcessError as e:
-            # Probably don't have the mozext extension installed.
+            # We probably don't have the mozext extension installed.
             ret = subprocess.call([self._hg, 'showconfig', 'extensions.mozext'])
             if ret:
                 raise Exception('Could not find candidate pushheads.\n\n'
                                 'You need to enable the "mozext" hg extension: '
                                 'see https://developer.mozilla.org/en-US/docs/Artifact_builds')
             raise e
 
-        # Probably don't have the pushlog database present locally.  Check.
+        # We probably don't have the pushlog database present locally.  Check.
         tree_pushheads = subprocess.check_output([self._hg, 'log',
             '--template', '{node}\n',
             '-r', 'last(pushhead("{tree}"))'.format(tree=tree)])
         # Filter blank lines.
         tree_pushheads = [ pushhead for pushhead in tree_pushheads.strip().split('\n') if pushhead ]
         if tree_pushheads:
             # Okay, we have some pushheads but no candidates.  This can happen
             # for legitimate reasons: old revisions with no upstream builds