Bug 1468917 - part 1: Make TSFTextStore not create native caret if ATOK 2016 is active r=m_kato a=lizzard
authorMasayuki Nakano <masayuki@d-toybox.com>
Thu, 21 Jun 2018 19:57:58 +0900
changeset 477834 b5967b6eb0a9b61be56f9cf6138ee251868b21cb
parent 477833 af29e6fccf0c023cd1b56fcd9f558b78ee48dd4f
child 477835 462984c1b4ffb94d76c7362d84867c2b3590eb19
push id9444
push userarchaeopteryx@coole-files.de
push dateSat, 07 Jul 2018 21:01:06 +0000
treeherdermozilla-beta@3c8ab5a011e3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersm_kato, lizzard
bugs1468917
milestone62.0
Bug 1468917 - part 1: Make TSFTextStore not create native caret if ATOK 2016 is active r=m_kato a=lizzard Old ATOK referred native caret position to decide its candidate window position. However, at least ATOK 2016 does not need to refer it. Additionally, if we create native caret for ATOK 2016, the candidate window position, ATOK 2016 refers the native caret only when we cannot return expected rect. Therefore, only immediately after modifying composition string, the position is different from actual position by a couple of pixels and that looks like flicks the candidate window. So, we should stop creating native caret for ATOK 2016 (as same as ATOK 2017). MozReview-Commit-ID: LsmVXCmRIzc
widget/windows/TSFTextStore.cpp
--- a/widget/windows/TSFTextStore.cpp
+++ b/widget/windows/TSFTextStore.cpp
@@ -1126,18 +1126,17 @@ public:
         NS_WARN_IF(!staticSink->EnsureInitActiveTIPKeyboard())) {
       return false;
     }
     return staticSink->IsATOKActiveInternal() &&
            (staticSink->IsATOK2011ActiveInternal() ||
             staticSink->IsATOK2012ActiveInternal() ||
             staticSink->IsATOK2013ActiveInternal() ||
             staticSink->IsATOK2014ActiveInternal() ||
-            staticSink->IsATOK2015ActiveInternal() ||
-            staticSink->IsATOK2016ActiveInternal());
+            staticSink->IsATOK2015ActiveInternal());
   }
 
 private:
   /****************************************************************************
    * Japanese TIP
    ****************************************************************************/
 
   // Note that TIP name may depend on the language of the environment.