Bug 1150430 - Set quickshare !visible and !enabled by default. r=mfinkle, a=sledru
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 06 Apr 2015 16:14:08 -0700
changeset 258446 b54c44cfa07e
parent 258445 2ffc047abd90
child 258447 9740c1d817f1
push id4669
push userryanvm@gmail.com
push date2015-04-13 16:55 +0000
treeherdermozilla-beta@333017ad43a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle, sledru
bugs1150430
milestone38.0
Bug 1150430 - Set quickshare !visible and !enabled by default. r=mfinkle, a=sledru
mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
mobile/android/base/resources/menu-v11/browser_app_menu.xml
mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
--- a/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
@@ -34,16 +34,18 @@
           android:icon="@drawable/ic_menu_share"
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
     <!-- We only show the quick share items so no need for an icon or title.
 
          The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visible="false"
+          android:enabled="false"
           android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"
           android:icon="@drawable/ic_menu_new_tab"
           android:title="@string/new_tab"/>
 
     <item android:id="@+id/new_private_tab"
--- a/mobile/android/base/resources/menu-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-v11/browser_app_menu.xml
@@ -34,16 +34,18 @@
           android:icon="@drawable/ic_menu_share"
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
     <!-- We only show the quick share items so no need for an icon or title.
 
          The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visible="false"
+          android:enabled="false"
           android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"
           android:icon="@drawable/ic_menu_new_tab"
           android:title="@string/new_tab"/>
 
     <item android:id="@+id/new_private_tab"
--- a/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
@@ -34,16 +34,18 @@
           android:icon="@drawable/ic_menu_share"
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
     <!-- We only show the quick share items so no need for an icon or title.
 
          The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visible="false"
+          android:enabled="false"
           android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"
           android:icon="@drawable/ic_menu_new_tab"
           android:title="@string/new_tab"/>
 
     <item android:id="@+id/new_private_tab"