Bug 1536768 - Check completeness of ObjectGroupDispatch in opt builds. r=jandem, a=pascalc
authorMatthew Gaudet <mgaudet@mozilla.com>
Wed, 03 Apr 2019 14:05:12 +0000
changeset 523089 b4fc373023dfb000596ab54f133200bb9ee4eff0
parent 523088 5929b22e9c9a197dfa214962cef54172ab98dadc
child 523090 8f151985cb7f8d5f590aa54dcd607698f66cb3d0
push id11050
push userryanvm@gmail.com
push dateTue, 09 Apr 2019 15:27:53 +0000
treeherdermozilla-beta@8f151985cb7f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem, pascalc
bugs1536768
milestone67.0
Bug 1536768 - Check completeness of ObjectGroupDispatch in opt builds. r=jandem, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25304
js/src/jit/CodeGenerator.cpp
--- a/js/src/jit/CodeGenerator.cpp
+++ b/js/src/jit/CodeGenerator.cpp
@@ -1482,23 +1482,23 @@ void CodeGenerator::visitObjectGroupDisp
     MOZ_ASSERT(found);
   }
 
   // Jump to fallback block if we have an unknown ObjectGroup. If there's no
   // fallback block, we should have handled all cases.
 
   if (!mir->hasFallback()) {
     MOZ_ASSERT(lastBranch.isInitialized());
-#ifdef DEBUG
+
     Label ok;
     lastBranch.relink(&ok);
     lastBranch.emit(masm);
     masm.assumeUnreachable("Unexpected ObjectGroup");
     masm.bind(&ok);
-#endif
+
     if (!isNextBlock(lastBlock)) {
       masm.jump(lastBlock->label());
     }
     return;
   }
 
   LBlock* fallback = skipTrivialBlocks(mir->getFallback())->lir();
   if (!lastBranch.isInitialized()) {