Bug 951770 - Fix signed-compare warning. r=bustage
☠☠ backed out by 2b6516c8713e ☠ ☠
authorRalph Giles <giles@mozilla.com>
Fri, 31 Jan 2014 22:22:14 -0800
changeset 182516 b4978efcdad91a964cb08bafc7c6791a33f7c977
parent 182515 4cddbc0d518340713b826a48689a534eaebc64e8
child 182517 ed795ed2bc38766ce86c6ea7f69e716b536558a8
push id3343
push userffxbld
push dateMon, 17 Mar 2014 21:55:32 +0000
treeherdermozilla-beta@2f7d3415f79f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs951770
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 951770 - Fix signed-compare warning. r=bustage Since we're just testing for equality here, casting mCodecDelay to a signed type is safe.
content/media/webm/WebMReader.cpp
--- a/content/media/webm/WebMReader.cpp
+++ b/content/media/webm/WebMReader.cpp
@@ -434,17 +434,17 @@ nsresult WebMReader::ReadMetadata(MediaI
           return NS_ERROR_FAILURE;
         }
 
         if (!InitOpusDecoder()) {
           Cleanup();
           return NS_ERROR_FAILURE;
         }
 
-        if (mCodecDelay != FramesToUsecs(mOpusParser->mPreSkip, mOpusParser->mRate).value()) {
+        if (static_cast<int64_t>(mCodecDelay) != FramesToUsecs(mOpusParser->mPreSkip, mOpusParser->mRate).value()) {
           LOG(PR_LOG_DEBUG, ("Values for CodecDelay and PreSkip do not match\n"))
           Cleanup();
           return NS_ERROR_FAILURE;
         }
 
         mInfo.mAudio.mRate = mOpusParser->mRate;
 
         mInfo.mAudio.mChannels = mOpusParser->mChannels;