Bug 1382954 - [Form Autofill] Expand the enable autofill checkbox to full width. r=lchang
authorScott Wu <scottcwwu@gmail.com>
Tue, 25 Jul 2017 17:36:22 +0800
changeset 420881 b402e104aafef7d1396f59b159eae342e467c454
parent 420880 814bf2e58ade5f5f2d114d1b7decbd1461c872d8
child 420882 8ae7fae10cb2d6918224e037e462cb063bd1be88
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslchang
bugs1382954
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382954 - [Form Autofill] Expand the enable autofill checkbox to full width. r=lchang MozReview-Commit-ID: 1ZTiXIWRA9O
browser/extensions/formautofill/FormAutofillPreferences.jsm
--- a/browser/extensions/formautofill/FormAutofillPreferences.jsm
+++ b/browser/extensions/formautofill/FormAutofillPreferences.jsm
@@ -65,17 +65,16 @@ FormAutofillPreferences.prototype = {
    * Create Form Autofill preference group
    *
    * @param  {XULDocument} document
    */
   createPreferenceGroup(document) {
     let formAutofillGroup;
     let addressAutofill = document.createElementNS(XUL_NS, "hbox");
     let addressAutofillCheckbox = document.createElementNS(XUL_NS, "checkbox");
-    let spacer = document.createElementNS(XUL_NS, "spacer");
     let savedAddressesBtn = document.createElementNS(XUL_NS, "button");
 
     if (this.useOldOrganization) {
       let caption = document.createElementNS(XUL_NS, "caption");
       let captionLabel = document.createElementNS(XUL_NS, "label");
 
       formAutofillGroup = document.createElementNS(XUL_NS, "groupbox");
       formAutofillGroup.hidden = document.location.href != "about:preferences#privacy";
@@ -100,21 +99,20 @@ FormAutofillPreferences.prototype = {
     savedAddressesBtn.setAttribute("label", this.bundle.GetStringFromName("savedAddresses"));
     addressAutofillCheckbox.setAttribute("label", this.bundle.GetStringFromName("enableAddressAutofill"));
 
     // Manually set the checked state
     if (this.isAutofillEnabled) {
       addressAutofillCheckbox.setAttribute("checked", true);
     }
 
-    spacer.flex = 1;
+    addressAutofillCheckbox.flex = 1;
 
     formAutofillGroup.appendChild(addressAutofill);
     addressAutofill.appendChild(addressAutofillCheckbox);
-    addressAutofill.appendChild(spacer);
     addressAutofill.appendChild(savedAddressesBtn);
   },
 
   /**
    * Handle events
    *
    * @param  {DOMEvent} event
    */