Bug 1396795 - mar_read_product_info_block: Value stored to 'location' is never read. r=rstrong
authorCosm <kausam2015@gmail.com>
Tue, 05 Sep 2017 22:53:16 -0700
changeset 428772 b3e93511d0376bb02821ee56e295e4e5903c3e07
parent 428627 a4252412b1ac3b90d0845e7c8af5f8231d4e8bce
child 428773 cae86ca80e62e087ca43604b0686e69836928ca7
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrstrong
bugs1396795
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1396795 - mar_read_product_info_block: Value stored to 'location' is never read. r=rstrong
modules/libmar/src/mar_read.c
--- a/modules/libmar/src/mar_read.c
+++ b/modules/libmar/src/mar_read.c
@@ -458,17 +458,16 @@ mar_read_product_info_block(MarFile *mar
       if (len >= 64) {
         infoBlock->MARChannelID = NULL;
         return -1;
       }
 
       /* Extract the version from the buffer */
       len = strlen(location);
       infoBlock->productVersion = location;
-      location += len + 1;
       if (len >= 32) {
         infoBlock->MARChannelID = NULL;
         infoBlock->productVersion = NULL;
         return -1;
       }
       infoBlock->MARChannelID = 
         strdup(infoBlock->MARChannelID);
       infoBlock->productVersion =