Backed out changeset cca78c809a20 (bug 1329351) for test_password_field_autocomplete.html failures a=backout CLOSED TREE
authorWes Kocher <wkocher@mozilla.com>
Thu, 12 Jan 2017 16:15:25 -0800
changeset 374187 b3b5aae6e351c0b356540df7c17f743f5b88b56e
parent 374186 4caa61eee820232d92d427a6077e56bb6eee21b8
child 374188 1cd2d1992f8a31a3ce92040c725b0787dc336bc2
push id6996
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 20:48:21 +0000
treeherdermozilla-beta@d89512dab048 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1329351
milestone53.0a1
backs outcca78c809a2069e5fecd2cc2070927ea29c97c52
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset cca78c809a20 (bug 1329351) for test_password_field_autocomplete.html failures a=backout CLOSED TREE MozReview-Commit-ID: 43v5di5qqHh
toolkit/components/satchel/nsFormFillController.cpp
--- a/toolkit/components/satchel/nsFormFillController.cpp
+++ b/toolkit/components/satchel/nsFormFillController.cpp
@@ -973,24 +973,16 @@ nsFormFillController::MaybeStartControll
   nsCOMPtr<nsIDOMHTMLElement> datalist;
   aInput->GetList(getter_AddRefs(datalist));
   bool hasList = datalist != nullptr;
 
   bool isPwmgrInput = false;
   if (mPwmgrInputs.Get(inputNode))
       isPwmgrInput = true;
 
-  // Don't show autocomplete on password fields regardless of datalist or
-  // autocomplete being enabled as we don't want to show form history on them.
-  // The GetType() check was more readable than !formControl->IsSingleLineTextControl(true)
-  // but this logic should be kept in-sync with that.
-  if (formControl->GetType() == NS_FORM_INPUT_PASSWORD && !isPwmgrInput) {
-    return;
-  }
-
   if (isPwmgrInput || hasList || autocomplete) {
     StartControllingInput(aInput);
   }
 }
 
 nsresult
 nsFormFillController::Focus(nsIDOMEvent* aEvent)
 {