Bug 1130203 - Review: Finish off share overlay nits. r=trivial
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 23 Mar 2015 11:28:56 -0700
changeset 264380 b3901be2155dc72f8dbac5ad7cf3d9f5fa61f0a9
parent 264379 4000ac847fc7d7521585b19bbebe858ac82b66db
child 264381 764ccc7fdc3031e7adbf2ac5b83e9b3304057e0a
push id4718
push userraliiev@mozilla.com
push dateMon, 11 May 2015 18:39:53 +0000
treeherdermozilla-beta@c20c4ef55f08 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstrivial
bugs1130203
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1130203 - Review: Finish off share overlay nits. r=trivial Changes include code alignment and clarifying comments.
mobile/android/base/resources/layout/overlay_share_dialog.xml
mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
--- a/mobile/android/base/resources/layout/overlay_share_dialog.xml
+++ b/mobile/android/base/resources/layout/overlay_share_dialog.xml
@@ -39,17 +39,17 @@
             style="@style/ShareOverlayTitle"
             android:textAppearance="@style/ShareOverlayTextAppearance.Header"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginBottom="20dp"
             android:textSize="12sp"
             android:scrollHorizontally="true"/>
 
-        <!-- TODO: Add back drop shadow? -->
+        <!-- TODO: Add back drop shadow (bug 1146488)? -->
         <!-- Buttons -->
         <!-- "Send to Firefox Sync" -->
         <org.mozilla.gecko.overlays.ui.SendTabList
             android:id="@+id/overlay_send_tab_btn"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:orientation="vertical"
             android:divider="@null"/>
--- a/mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
+++ b/mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!-- The first item's background is unique and these views are reused
      so the background is set dynamically. -->
-<org.mozilla.gecko.overlays.ui.OverlayDialogButton xmlns:android="http://schemas.android.com/apk/res/android"
+<org.mozilla.gecko.overlays.ui.OverlayDialogButton
+    xmlns:android="http://schemas.android.com/apk/res/android"
     style="@style/ShareOverlayRow"
     android:id="@+id/overlay_send_tab_item"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"/>