Bug 1510961 - "Class Structure Warning: 'private' method declared 'final'". r=etoop
authorTimm <lui.timm@gmail.com>
Tue, 05 Mar 2019 17:41:00 +0200
changeset 520876 b2f184631538e67dcd7bca6eb82510abd6d8974b
parent 520875 847db9dff0bcb650c871ccf4f002dc6eccf5a161
child 520877 9dde4b9b46e23680556871b3fdca837bb375b809
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersetoop
bugs1510961
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510961 - "Class Structure Warning: 'private' method declared 'final'". r=etoop
mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntime.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java
@@ -207,17 +207,17 @@ public final class GeckoLoader {
 
         loadMozGlue(context);
         loadLibsSetupLocked(context);
         loadNSSLibsNative();
         sNSSLibsLoaded = true;
     }
 
     @SuppressWarnings("deprecation")
-    private static final String getCPUABI() {
+    private static String getCPUABI() {
         return android.os.Build.CPU_ABI;
     }
 
     /**
      * Copy a library out of our APK.
      *
      * @param context a Context.
      * @param lib the name of the library; e.g., "mozglue".
@@ -354,34 +354,34 @@ public final class GeckoLoader {
             message.append(", libx=" + nativeLibLibExists);
         } catch (Throwable e) {
             message.append(", nativeLib fail.");
         }
 
         return message.toString();
     }
 
-    private static final boolean attemptLoad(final String path) {
+    private static boolean attemptLoad(final String path) {
         try {
             System.load(path);
             return true;
         } catch (Throwable e) {
             Log.wtf(LOGTAG, "Couldn't load " + path + ": " + e);
         }
 
         return false;
     }
 
     /**
      * The first two attempts at loading a library: directly, and
      * then using the app library path.
      *
      * Returns null or the cause exception.
      */
-    private static final Throwable doLoadLibraryExpected(final Context context, final String lib) {
+    private static Throwable doLoadLibraryExpected(final Context context, final String lib) {
         try {
             // Attempt 1: the way that should work.
             System.loadLibrary(lib);
             return null;
         } catch (Throwable e) {
             Log.wtf(LOGTAG, "Couldn't load " + lib + ". Trying native library dir.");
 
             // Attempt 2: use nativeLibraryDir, which should also work.
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntime.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntime.java
@@ -158,17 +158,17 @@ public final class GeckoRuntime implemen
                     context.startForegroundService(i);
                 } else {
                     context.startService(i);
                 }
             }
         }
     };
 
-    private static final String getProcessName(Context context) {
+    private static String getProcessName(Context context) {
         final ActivityManager manager = (ActivityManager)context.getSystemService(Context.ACTIVITY_SERVICE);
         for (final ActivityManager.RunningAppProcessInfo info : manager.getRunningAppProcesses()) {
             if (info.pid == Process.myPid()) {
                 return info.processName;
             }
         }
 
         return null;