bug 1331320 document requestFlakyTimeout for crashAndGetCrashServiceRecord() r=glandium
☠☠ backed out by ec799efea60c ☠ ☠
authorKarl Tomlinson <karlt+@karlt.net>
Mon, 16 Jan 2017 18:57:03 +1300
changeset 374659 b272ced2faa9ebf8ab06017040af92be54d3ff96
parent 374658 cee10a2c348a6768803bf01b7852d811df50b587
child 374660 fd57bcd5daf2e1dd79021f4fa7ec659ad4b40d21
push id6996
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 20:48:21 +0000
treeherdermozilla-beta@d89512dab048 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1331320
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1331320 document requestFlakyTimeout for crashAndGetCrashServiceRecord() r=glandium MozReview-Commit-ID: 4l2qxJfRbkq
dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
--- a/dom/plugins/test/mochitest/test_CrashService_crash.html
+++ b/dom/plugins/test/mochitest/test_CrashService_crash.html
@@ -1,17 +1,18 @@
 <head>
   <title>nsICrashService plugin crash</title>
   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <script type="application/javascript" src="plugin-utils.js"></script>
 
 <body>
   <script class="testbody" type="application/javascript">
   SimpleTest.waitForExplicitFinish();
-  SimpleTest.requestFlakyTimeout("untriaged");
+  SimpleTest.requestFlakyTimeout(
+    "crashAndGetCrashServiceRecord() polls for async crash recording");
   SimpleTest.requestCompleteLog();
   setTestPluginEnabledState(SpecialPowers.Ci.nsIPluginTag.STATE_ENABLED);
 
   window.frameLoaded = function frameLoaded_toCrash() {
     SimpleTest.expectChildProcessCrash();
 
     crashAndGetCrashServiceRecord("crash", function (cm, crash) {
       var isPluginCrash = crash.isOfType(cm.PROCESS_TYPE_PLUGIN, cm.CRASH_TYPE_CRASH);
--- a/dom/plugins/test/mochitest/test_CrashService_hang.html
+++ b/dom/plugins/test/mochitest/test_CrashService_hang.html
@@ -1,17 +1,18 @@
 <head>
   <title>nsICrashService plugin hang</title>
   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <script type="application/javascript" src="plugin-utils.js"></script>
 
 <body>
   <script class="testbody" type="application/javascript">
   SimpleTest.waitForExplicitFinish();
-  SimpleTest.requestFlakyTimeout("untriaged");
+  SimpleTest.requestFlakyTimeout(
+    "crashAndGetCrashServiceRecord() polls for async crash recording");
   SimpleTest.requestCompleteLog();
   setTestPluginEnabledState(SpecialPowers.Ci.nsIPluginTag.STATE_ENABLED);
 
   window.frameLoaded = function frameLoaded_toCrash() {
     SimpleTest.expectChildProcessCrash();
 
     // the default timeout is annoying high for mochitest runs
     var timeoutPref = "dom.ipc.plugins.timeoutSecs";