Bug 766359 - Background update of add-ons/addons: Make success notification/toast more informative
authorMark Capella <markcapella@twcny.rr.com>
Thu, 01 Aug 2013 20:55:23 -0400
changeset 153315 b1f115fb574d5faacf74db664ed79d4808ab41df
parent 153314 10468c8e4d75ff5dca0bf97c1c263907f595e298
child 153316 9a5f4bbd4fcb22379cb2fe7f50a4326f0ca9fdf8
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs766359
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 766359 - Background update of add-ons/addons: Make success notification/toast more informative
mobile/android/chrome/content/browser.js
--- a/mobile/android/chrome/content/browser.js
+++ b/mobile/android/chrome/content/browser.js
@@ -5478,18 +5478,21 @@ var XPInstallObserver = {
     if (aInstall.existingAddon && (aInstall.existingAddon.pendingOperations & AddonManager.PENDING_UPGRADE))
       needsRestart = true;
     else if (aAddon.pendingOperations & AddonManager.PENDING_INSTALL)
       needsRestart = true;
 
     if (needsRestart) {
       this.showRestartPrompt();
     } else {
-      let message = Strings.browser.GetStringFromName("alertAddonsInstalledNoRestart");
-      NativeWindow.toast.show(message, "short");
+      // Display completion message for new installs or updates not done Automatically
+      if (!aInstall.existingAddon || !AddonManager.shouldAutoUpdate(aInstall.existingAddon)) {
+        let message = Strings.browser.GetStringFromName("alertAddonsInstalledNoRestart");
+        NativeWindow.toast.show(message, "short");
+      }
     }
   },
 
   onInstallFailed: function(aInstall) {
     NativeWindow.toast.show(Strings.browser.GetStringFromName("alertAddonsFail"), "short");
   },
 
   onDownloadProgress: function xpidm_onDownloadProgress(aInstall) {},