Bug 1508935 - Create more accessibles from the HTML markup map rather than layout frame types, r=Jamie
authorMarco Zehe <mzehe@mozilla.com>
Fri, 23 Nov 2018 06:49:00 +0000
changeset 504222 b188f2d1917b840fc6327246444afbbb141964de
parent 504221 a31b6b37d11c256b60b539495be002114baff3c7
child 504223 ad6143ff142da2f47fe8fcbfd025174a791707bf
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersJamie
bugs1508935
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1508935 - Create more accessibles from the HTML markup map rather than layout frame types, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D12639
accessible/base/MarkupMap.h
--- a/accessible/base/MarkupMap.h
+++ b/accessible/base/MarkupMap.h
@@ -37,16 +37,24 @@ MARKUPMAP(article,
 MARKUPMAP(aside,
           New_HyperText,
           roles::LANDMARK)
 
 MARKUPMAP(blockquote,
           New_HyperText,
           roles::BLOCKQUOTE)
 
+MARKUPMAP(
+  button,
+  [](Element* aElement, Accessible* aContext) -> Accessible* {
+     return new HTMLButtonAccessible(aElement, aContext->Document());
+  },
+  0
+)
+
 MARKUPMAP(dd,
           New_HTMLDtOrDd<HyperTextAccessibleWrap>,
           roles::DEFINITION)
 
 MARKUPMAP(del,
           New_HyperText,
           roles::CONTENT_DELETION)
 
@@ -83,16 +91,24 @@ MARKUPMAP(
   [](Element* aElement, Accessible* aContext) -> Accessible* {
      return new HTMLFigureAccessible(aElement, aContext->Document());
   },
   roles::FIGURE,
   Attr(xmlroles, figure)
 )
 
 MARKUPMAP(
+  fieldset,
+  [](Element* aElement, Accessible* aContext) -> Accessible* {
+     return new HTMLGroupboxAccessible(aElement, aContext->Document());
+  },
+  0
+)
+
+MARKUPMAP(
   form,
   [](Element* aElement, Accessible* aContext) -> Accessible* {
      return new HTMLFormAccessible(aElement, aContext->Document());
   },
   0
 )
 
 MARKUPMAP(
@@ -131,16 +147,24 @@ MARKUPMAP(h5,
           New_HyperText,
           roles::HEADING)
 
 MARKUPMAP(h6,
           New_HyperText,
           roles::HEADING)
 
 MARKUPMAP(
+  hr,
+  [](Element* aElement, Accessible* aContext) -> Accessible* {
+     return new HTMLHRAccessible(aElement, aContext->Document());
+  },
+  0
+)
+
+MARKUPMAP(
   input,
   [](Element* aElement, Accessible* aContext) -> Accessible* {
      if (aElement->AttrValueIs(kNameSpaceID_None, nsGkAtoms::type,
                               nsGkAtoms::checkbox, eIgnoreCase)) {
        return new CheckboxAccessible(aElement, aContext->Document());
      }
      if (aElement->AttrValueIs(kNameSpaceID_None, nsGkAtoms::type,
                               nsGkAtoms::radio, eIgnoreCase)) {