Bumping gaia.json for 1 gaia-central revision(s) a=gaia-bump
authorGaia Pushbot <release+gaiajson@mozilla.com>
Sun, 27 Oct 2013 21:14:10 -0700
changeset 166271 b1536bdf87ae722d469dd42e2a403ebe93bce259
parent 166270 00f66158905b97d35c99c0ab1cd9d042fd2abe41
child 166272 ba80ddd46af92c7c2d0a40aebdd4b02d2dd9931f
push id3066
push userakeybl@mozilla.com
push dateMon, 09 Dec 2013 19:58:46 +0000
treeherdermozilla-beta@a31a0dce83aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs920546, 1, 2, 3
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bumping gaia.json for 1 gaia-central revision(s) a=gaia-bump Truncated some number of revisions since the previous bump. ======== https://hg.mozilla.org/integration/gaia-central/rev/373644db99ce Author: Rick Waldron <waldron.rick@gmail.com> Desc: Bug 920546 - [Messages] Short-term fixes for the recipient panel r=julienw https://bugzilla.mozilla.org/show_bug.cgi?id=920546 - Apply new "invalid recipient" indicator style - Decouple searchContact from list display - Create ThreadUI.listContact(...) - Create ThreadUI.validateContact(...) - Adds two level validation: - Is the entry questionable? - This kicks off a silent search for matching contacts - If there are one or more matches, use the first to create a Recipient - Is the entry invalid? - This state is reached if no contacts could be found for the typed value. - Prevents enableSend - Prevents "export" of recipient entry at Send (when mixed with multiple valid recipients) - Refactor Utils.getContactDisplayInfo logic - Adds tests for enableSend - Adds tests for questionable Recipient detection. Changes, post review: > Bug 1: > - enter a bogus recipient, press enter to "accept" it > - press backspace => the cursor is correctly inside the contenteditable element, but it's still "red" and the keyboard is hiding Fixed by adding CSS rules: [contenteditable=false].attention [contenteditable=true].attention --- > Bug 2: > - with the recipient light workload, that has a "Adam L. Card" contact > - typing exactly "Adam L. Card" => no match > - typing "Adam Card" => match Yep, this has always been true. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=860804 --- > Bug 3: > - add text in the composer > - add a bogus contact => the send button is enabled, should be disabled Fixed by being more explicit in enableSend: Set hasRecipients to true based on the following conditions: 1. There is a valid recipients object 2. One of the following is true: - The recipients object contains at least 1 valid recipient - OR - - There is >1 character typed and the value will not evaluate to a NaN Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
--- a/b2g/config/gaia.json
+++ b/b2g/config/gaia.json
@@ -1,4 +1,4 @@
-    "revision": "c73e725d0176f8749b668913f2d1896d329ea5c3", 
+    "revision": "373644db99ce567cad011da89e81f1a46247c54a", 
     "repo_path": "/integration/gaia-central"