servo: Merge #17784 - constellation: Remove unused title attribute from Pipeline struct (from omakk:master); r=jdm
authorOmar Akkila <omakkila@gmail.com>
Wed, 19 Jul 2017 08:20:35 -0700
changeset 418374 b11f89deba4e240ea0cbfafac6d2eb3488e2699a
parent 418373 5a4f7cc9980579506b199748c9d5cc1479d527c2
child 418375 967111e5be01c016ba1332f7985729efc4d07fa2
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdm
bugs17784, 15714
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #17784 - constellation: Remove unused title attribute from Pipeline struct (from omakk:master); r=jdm <!-- Please describe your changes on the following line: --> Removes title attribute from constellation::Pipeline since it is never used --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15714 - [X] These changes do not require tests because it's a very simple cleanup Source-Repo: https://github.com/servo/servo Source-Revision: 4b69665beb6cf03118b0f811f9dbc076f51b1aae
servo/components/constellation/pipeline.rs
--- a/servo/components/constellation/pipeline.rs
+++ b/servo/components/constellation/pipeline.rs
@@ -70,19 +70,16 @@ pub struct Pipeline {
     /// A channel to the compositor.
     pub compositor_proxy: CompositorProxy,
 
     /// The most recently loaded URL in this pipeline.
     /// Note that this URL can change, for example if the page navigates
     /// to a hash URL.
     pub url: ServoUrl,
 
-    /// The title of the most recently-loaded page.
-    pub title: Option<String>,
-
     /// Whether this pipeline is currently running animations. Pipelines that are running
     /// animations cause composites to be continually scheduled.
     pub running_animations: bool,
 
     /// The child browsing contexts of this pipeline (these are iframes in the document).
     pub children: Vec<BrowsingContextId>,
 
     /// Whether this pipeline is in private browsing mode.
@@ -311,17 +308,16 @@ impl Pipeline {
             id: id,
             browsing_context_id: browsing_context_id,
             top_level_browsing_context_id: top_level_browsing_context_id,
             parent_info: parent_info,
             event_loop: event_loop,
             layout_chan: layout_chan,
             compositor_proxy: compositor_proxy,
             url: url,
-            title: None,
             children: vec!(),
             running_animations: false,
             visible: visible,
             is_private: is_private,
         };
 
         pipeline.notify_visibility();