Bug 1004671 - SpecialPowers observer isn't robust enough in OOP. r=ted, a=test-only
authorJoel Maher <jmaher@mozilla.com>
Fri, 16 May 2014 06:55:34 -0400
changeset 192311 b01e7d87ef31
parent 192310 20143f06748b
child 192312 ebf5c0367290
push id3566
push userryanvm@gmail.com
push date2014-05-20 13:28 +0000
treeherdermozilla-beta@7d6a74b90622 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted, test-only
bugs1004671
milestone30.0
Bug 1004671 - SpecialPowers observer isn't robust enough in OOP. r=ted, a=test-only
testing/specialpowers/content/SpecialPowersObserverAPI.js
--- a/testing/specialpowers/content/SpecialPowersObserverAPI.js
+++ b/testing/specialpowers/content/SpecialPowersObserverAPI.js
@@ -66,17 +66,21 @@ function parseKeyValuePairsFromFile(file
   fstream.close();
   return parseKeyValuePairs(contents);
 }
 
 SpecialPowersObserverAPI.prototype = {
 
   _observe: function(aSubject, aTopic, aData) {
     function addDumpIDToMessage(propertyName) {
-      var id = aSubject.getPropertyAsAString(propertyName);
+      try {
+        var id = aSubject.getPropertyAsAString(propertyName);
+      } catch(ex) {
+        var id = null;
+      }
       if (id) {
         message.dumpIDs.push({id: id, extension: "dmp"});
         message.dumpIDs.push({id: id, extension: "extra"});
       }
     }
 
     switch(aTopic) {
       case "plugin-crashed":