Backed out changeset a6c8c4ccb5e7 (bug 1113005) because of mochitest-4 bustage on a CLOSED TREE
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 19 Dec 2014 14:26:52 -0500
changeset 246519 afd92b25e239747e029b5677ce1fea2a8be996a7
parent 246518 6cd496d732f7b8b58e9ba5c7410d50b284865291
child 246520 5a082a183de4bc87e28ec3e29557162ed20fb632
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1113005
milestone37.0a1
backs outa6c8c4ccb5e7caffcf64b3c6ce75cae628014fa1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a6c8c4ccb5e7 (bug 1113005) because of mochitest-4 bustage on a CLOSED TREE
xpcom/string/nsTStringObsolete.cpp
--- a/xpcom/string/nsTStringObsolete.cpp
+++ b/xpcom/string/nsTStringObsolete.cpp
@@ -500,17 +500,17 @@ nsTString_CharT::ReplaceSubstring( const
 
   // Make sure that we can mutate our buffer.
   char_type* oldData;
   uint32_t oldFlags;
   if (!MutatePrep(XPCOM_MAX(mLength, newLength), &oldData, &oldFlags))
     return;
   if (oldData) {
     // Copy all of the old data to the new buffer.
-    char_traits::copy(mData, oldData, XPCOM_MIN(mLength, newLength));
+    char_traits::copy(mData, oldData, XPCOM_MAX(mLength, newLength));
     ::ReleaseData(oldData, oldFlags);
   }
 
   if (aTarget.Length() >= aNewValue.Length()) {
     // In the shrinking case, start filling the buffer from the beginning.
     const uint32_t delta = (aTarget.Length() - aNewValue.Length());
     for (i = 1; i < nonMatching.Length(); ++i) {
       // When we move the i'th non-matching segment into position, we need to