Bug 1502036 - Subtest results for raptor speedometer have incorrect lower_is_better setting; r=jmaher
authorRob Wood <rwood@mozilla.com>
Fri, 16 Nov 2018 17:25:32 +0000
changeset 503261 aef6ff7f100d7b6748020d3c83f1303cf084e0a6
parent 503260 6875c54fd481eeb715a96474b5babb2734423d04
child 503262 b6010c470851c2a92036ae40c76665048575a20c
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1502036
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1502036 - Subtest results for raptor speedometer have incorrect lower_is_better setting; r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D12142
testing/raptor/raptor/manifest.py
--- a/testing/raptor/raptor/manifest.py
+++ b/testing/raptor/raptor/manifest.py
@@ -94,18 +94,22 @@ def write_test_settings_json(args, test_
     if test_details.get("lower_is_better", "true") == "false":
         test_settings['raptor-options']['lower_is_better'] = False
     else:
         test_settings['raptor-options']['lower_is_better'] = True
 
     # support optional subtest unit/lower_is_better fields, default to main test values if not set
     val = test_details.get('subtest_unit', test_settings['raptor-options']['unit'])
     test_settings['raptor-options']['subtest_unit'] = val
-    val = test_details.get('subtest_lower', test_settings['raptor-options']['lower_is_better'])
-    test_settings['raptor-options']['subtest_lower_is_better'] = val
+    val = test_details.get('subtest_lower_is_better',
+                           test_settings['raptor-options']['lower_is_better'])
+    if val == "false":
+        test_settings['raptor-options']['subtest_lower_is_better'] = False
+    else:
+        test_settings['raptor-options']['subtest_lower_is_better'] = True
 
     if test_details.get("alert_threshold", None) is not None:
         test_settings['raptor-options']['alert_threshold'] = float(test_details['alert_threshold'])
 
     # if gecko profiling is enabled, write profiling settings for webext
     if test_details.get("gecko_profile", False):
         test_settings['raptor-options']['gecko_profile'] = True
         # when profiling, if webRender is enabled we need to set that, so