Backout 2657b58d787c (bug 789482). a=akeybl
authorTimothy Nikkel <tnikkel@gmail.com>
Fri, 02 Nov 2012 17:40:32 -0500
changeset 116608 aee404ebbdae2215f1f3eff0383aaeb0cd1fb937
parent 116607 dd53d0988e6ff9c8587066fde0ea1ef31d861c2b
child 116609 573627e62736389681a5421ee9f6f50da465dc1f
push id1708
push userakeybl@mozilla.com
push dateMon, 19 Nov 2012 21:10:21 +0000
treeherdermozilla-beta@27b14fe50103 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersakeybl
bugs789482
milestone18.0a2
backs out2657b58d787c6bb5dbaf8ee1c02a383a13c953ff
Backout 2657b58d787c (bug 789482). a=akeybl
view/src/nsView.cpp
--- a/view/src/nsView.cpp
+++ b/view/src/nsView.cpp
@@ -243,21 +243,19 @@ void nsView::DoResetWidgetBounds(bool aM
   }
   
   nsIntRect curBounds;
   mWindow->GetClientBounds(curBounds);
 
   nsWindowType type;
   mWindow->GetWindowType(type);
 
-  if (type == eWindowType_popup &&
-      ((curBounds.IsEmpty() && mDimBounds.IsEmpty()) ||
-       mVis == nsViewVisibility_kHide)) {
-    // Don't manipulate empty or hidden popup widgets. For example there's no
-    // point moving hidden comboboxes around, or doing X server roundtrips
+  if (curBounds.IsEmpty() && mDimBounds.IsEmpty() && type == eWindowType_popup) {
+    // Don't manipulate empty popup widgets. For example there's no point
+    // moving hidden comboboxes around, or doing X server roundtrips
     // to compute their true screen position. This could mean that WidgetToScreen
     // operations on these widgets don't return up-to-date values, but popup
     // positions aren't reliable anyway because of correction to be on or off-screen.
     return;
   }
 
   NS_PRECONDITION(mWindow, "Why was this called??");