Bug 1176034 followup: Annotate ForceCloseHelper method 'ActorCreated' as 'override', in MessagePort.cpp. rs=ehsan
☠☠ backed out by 929cf0565c25 ☠ ☠
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 23 Jun 2015 18:55:24 -0700
changeset 280841 ae700a7a4c5e73f79aa3710e367c638c57ffbeda
parent 280840 c3c503368fdd3e3987deb918cd2d07187bf90091
child 280842 4a7a351142381b56eb2e8bb732723d87d3b185b9
push id4932
push userjlund@mozilla.com
push dateMon, 10 Aug 2015 18:23:06 +0000
treeherdermozilla-beta@6dd5a4f5f745 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1176034
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1176034 followup: Annotate ForceCloseHelper method 'ActorCreated' as 'override', in MessagePort.cpp. rs=ehsan
dom/messagechannel/MessagePort.cpp
--- a/dom/messagechannel/MessagePort.cpp
+++ b/dom/messagechannel/MessagePort.cpp
@@ -279,17 +279,17 @@ private:
 
   ~ForceCloseHelper() {}
 
   void ActorFailed() override
   {
     MOZ_CRASH("Failed to create a PBackgroundChild actor!");
   }
 
-  void ActorCreated(mozilla::ipc::PBackgroundChild* aActor)
+  void ActorCreated(mozilla::ipc::PBackgroundChild* aActor) override
   {
     ForceClose(mIdentifier);
   }
 
   const MessagePortIdentifier mIdentifier;
 };
 
 NS_IMPL_ISUPPORTS(ForceCloseHelper, nsIIPCBackgroundChildCreateCallback)