Bug 1586758 [wpt PR 19549] - Convert WebUsbService client to use BrowserInterfaceBroker, a=testonly
authorMiyoung Shin <myid.shin@igalia.com>
Mon, 14 Oct 2019 13:39:52 +0000
changeset 559558 ae5c60e71f94f2de3a7ad55e982c8e2c7e8fd08b
parent 559557 cdc6a42731a9acf2745cc095351108de24b3ccca
child 559559 65016d3b9885fe7e43f4035837c73071e40e548b
push id12177
push usercsabou@mozilla.com
push dateMon, 21 Oct 2019 14:52:16 +0000
treeherdermozilla-beta@1918a9cd33bc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1586758, 19549, 936482, 1844005, 703611
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1586758 [wpt PR 19549] - Convert WebUsbService client to use BrowserInterfaceBroker, a=testonly Automatic update from web-platform-tests Convert WebUsbService client to use BrowserInterfaceBroker This change converts WebUsbService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I03f8d6b061eed920ffd68305702f73fff66fe871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844005 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#703611} -- wpt-commits: 965481541d2f8e6b4b347a8048031985a1fa8e27 wpt-pr: 19549
testing/web-platform/tests/resources/chromium/webusb-child-test.js
testing/web-platform/tests/resources/chromium/webusb-test.js
--- a/testing/web-platform/tests/resources/chromium/webusb-child-test.js
+++ b/testing/web-platform/tests/resources/chromium/webusb-child-test.js
@@ -9,17 +9,17 @@
 
     // Run Chromium specific set up code.
     if (typeof MojoInterfaceInterceptor !== 'undefined') {
       let messageChannel = new MessageChannel();
       messageChannel.port1.onmessage = async (messageEvent) => {
         if (messageEvent.data.type === 'Attach') {
           messageEvent.data.interfaces.forEach(interfaceName => {
             let interfaceInterceptor =
-                new MojoInterfaceInterceptor(interfaceName);
+                new MojoInterfaceInterceptor(interfaceName, "context", true);
             interfaceInterceptor.oninterfacerequest =
               e => messageChannel.port1.postMessage({
                 type: interfaceName,
                 handle: e.handle
               }, [e.handle]);
             interfaceInterceptor.start();
           });
 
--- a/testing/web-platform/tests/resources/chromium/webusb-test.js
+++ b/testing/web-platform/tests/resources/chromium/webusb-test.js
@@ -471,17 +471,17 @@ class USBTest {
 
     // Be ready to handle 'ReadyForAttachment' message from child iframes.
     if ('window' in self) {
       getMessagePort(window);
     }
 
     internal.webUsbService = new FakeWebUsbService();
     internal.webUsbServiceInterceptor =
-        new MojoInterfaceInterceptor(blink.mojom.WebUsbService.name);
+        new MojoInterfaceInterceptor(blink.mojom.WebUsbService.name, "context", true);
     internal.webUsbServiceInterceptor.oninterfacerequest =
         e => internal.webUsbService.addBinding(e.handle);
     internal.webUsbServiceInterceptor.start();
 
     // Wait for a call to GetDevices() to pass between the renderer and the
     // mock in order to establish that everything is set up.
     await navigator.usb.getDevices();
     internal.initialized = true;