Bug 1495381 - Show Manifest URL for addon target only with This Firefox;r=daisuke
authorJulian Descottes <jdescottes@mozilla.com>
Wed, 14 Nov 2018 17:15:18 +0000
changeset 502852 ae26c60a0f50dc98534e7e2bd65ee62254cb71f6
parent 502851 a97b66cfcfd1e2a1c7277417e6a8cb3929bc1a5c
child 502853 682c6a11531bda7811aa573f86d4eb30cc2c43a1
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdaisuke
bugs1495381
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1495381 - Show Manifest URL for addon target only with This Firefox;r=daisuke Depends on D11643 Differential Revision: https://phabricator.services.mozilla.com/D11666
devtools/client/aboutdebugging-new/src/actions/debug-targets.js
--- a/devtools/client/aboutdebugging-new/src/actions/debug-targets.js
+++ b/devtools/client/aboutdebugging-new/src/actions/debug-targets.js
@@ -138,21 +138,29 @@ function requestTabs() {
     }
   };
 }
 
 function requestExtensions() {
   return async (dispatch, getState) => {
     dispatch({ type: REQUEST_EXTENSIONS_START });
 
+    const runtime = getCurrentRuntime(getState().runtimes);
     const client = getCurrentClient(getState().runtimes);
 
     try {
       const { addons } = await client.listAddons();
       const extensions = addons.filter(a => a.debuggable);
+      if (runtime.type !== RUNTIMES.THIS_FIREFOX) {
+        // manifestURL can only be used when debugging local addons, remove this
+        // information for the extension data.
+        extensions.forEach(extension => {
+          extension.manifestURL = null;
+        });
+      }
       const installedExtensions = extensions.filter(e => !e.temporarilyInstalled);
       const temporaryExtensions = extensions.filter(e => e.temporarilyInstalled);
 
       dispatch({
         type: REQUEST_EXTENSIONS_SUCCESS,
         installedExtensions,
         temporaryExtensions,
       });