Bug 1365278 - Remove WORD_CACHE_* telemetry probes that provide little value for their cost. r=milan
authorJonathan Kew <jkew@mozilla.com>
Mon, 29 May 2017 16:19:36 +0100
changeset 409310 adc68cbe1295500e348dd3ff8e6737f7b77006b0
parent 409309 4381d9011522dd86fd0aefdfb15c65f7ea9c9227
child 409311 930b86eafc2c0063ac47e099ef3fea8ff9d30ea6
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmilan
bugs1365278
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1365278 - Remove WORD_CACHE_* telemetry probes that provide little value for their cost. r=milan
gfx/thebes/gfxFont.cpp
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/gfx/thebes/gfxFont.cpp
+++ b/gfx/thebes/gfxFont.cpp
@@ -2599,34 +2599,26 @@ gfxFont::GetShapedWord(DrawTarget *aDraw
 
     CacheHashEntry *entry = mWordCache->PutEntry(key);
     if (!entry) {
         NS_WARNING("failed to create word cache entry - expect missing text");
         return nullptr;
     }
     gfxShapedWord* sw = entry->mShapedWord.get();
 
-    bool isContent = !mStyle.systemFont;
-
     if (sw) {
         sw->ResetAge();
-        Telemetry::Accumulate((isContent ? Telemetry::WORD_CACHE_HITS_CONTENT :
-                                   Telemetry::WORD_CACHE_HITS_CHROME),
-                              aLength);
 #ifndef RELEASE_OR_BETA
         if (aTextPerf) {
             aTextPerf->current.wordCacheHit++;
         }
 #endif
         return sw;
     }
 
-    Telemetry::Accumulate((isContent ? Telemetry::WORD_CACHE_MISSES_CONTENT :
-                               Telemetry::WORD_CACHE_MISSES_CHROME),
-                          aLength);
 #ifndef RELEASE_OR_BETA
     if (aTextPerf) {
         aTextPerf->current.wordCacheMiss++;
     }
 #endif
 
     sw = gfxShapedWord::Create(aText, aLength, aRunScript, aAppUnitsPerDevUnit,
                                aFlags, aRounding);
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -1645,48 +1645,16 @@
   "GRADIENT_RETENTION_TIME": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "linear",
     "high": 10000,
     "n_buckets": 20,
     "description": "Maximum retention time for the gradient cache. (ms)"
   },
-  "WORD_CACHE_HITS_CONTENT": {
-    "record_in_processes": ["main", "content"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 256,
-    "n_buckets": 30,
-    "description": "Word cache hits, content text (chars)"
-  },
-  "WORD_CACHE_HITS_CHROME": {
-    "record_in_processes": ["main", "content"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 256,
-    "n_buckets": 30,
-    "description": "Word cache hits, chrome text (chars)"
-  },
-  "WORD_CACHE_MISSES_CONTENT": {
-    "record_in_processes": ["main", "content"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 256,
-    "n_buckets": 30,
-    "description": "Word cache misses, content text (chars)"
-  },
-  "WORD_CACHE_MISSES_CHROME": {
-    "record_in_processes": ["main", "content"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 256,
-    "n_buckets": 30,
-    "description": "Word cache misses, chrome text (chars)"
-  },
   "FONT_CACHE_HIT": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "boolean",
     "description": "font cache hit"
   },
   "BAD_FALLBACK_FONT": {
     "record_in_processes": ["main", "content"],
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -621,20 +621,16 @@
     "WEBCRYPTO_ALG",
     "WEBCRYPTO_EXTRACTABLE_ENC",
     "WEBCRYPTO_EXTRACTABLE_GENERATE",
     "WEBCRYPTO_EXTRACTABLE_IMPORT",
     "WEBCRYPTO_EXTRACTABLE_SIG",
     "WEBCRYPTO_METHOD",
     "WEBCRYPTO_RESOLVED",
     "WEBSOCKETS_HANDSHAKE_TYPE",
-    "WORD_CACHE_HITS_CHROME",
-    "WORD_CACHE_HITS_CONTENT",
-    "WORD_CACHE_MISSES_CHROME",
-    "WORD_CACHE_MISSES_CONTENT",
     "XMLHTTPREQUEST_ASYNC_OR_SYNC",
     "XUL_CACHE_DISABLED"
   ],
   "bug_numbers": [
     "A11Y_CONSUMERS",
     "A11Y_IATABLE_USAGE_FLAG",
     "A11Y_INSTANTIATED_FLAG",
     "A11Y_ISIMPLEDOM_USAGE_FLAG",
@@ -1598,20 +1594,16 @@
     "WEBRTC_VIDEO_QUALITY_INBOUND_PACKETLOSS_RATE",
     "WEBRTC_VIDEO_QUALITY_OUTBOUND_BANDWIDTH_KBITS",
     "WEBRTC_VIDEO_QUALITY_OUTBOUND_JITTER",
     "WEBRTC_VIDEO_QUALITY_OUTBOUND_PACKETLOSS_RATE",
     "WEBRTC_VIDEO_QUALITY_OUTBOUND_RTT",
     "WEBRTC_VIDEO_RECOVERY_AFTER_ERROR_PER_MIN",
     "WEBRTC_VIDEO_RECOVERY_BEFORE_ERROR_PER_MIN",
     "WEBSOCKETS_HANDSHAKE_TYPE",
-    "WORD_CACHE_HITS_CHROME",
-    "WORD_CACHE_HITS_CONTENT",
-    "WORD_CACHE_MISSES_CHROME",
-    "WORD_CACHE_MISSES_CONTENT",
     "XMLHTTPREQUEST_ASYNC_OR_SYNC",
     "XUL_CACHE_DISABLED"
   ],
   "n_buckets": [
     "MEMORY_JS_GC_HEAP",
     "MEMORY_HEAP_ALLOCATED",
     "SYSTEM_FONT_FALLBACK_SCRIPT",
     "HTTP_REQUEST_PER_PAGE_FROM_CACHE",