Bug 1404057 - stylo: `all` shorthand should not apply to internal properties. r=xidorn, a=ritu
authorManish Goregaokar <manishsmail@gmail.com>
Wed, 04 Oct 2017 20:57:24 -0500
changeset 432312 ad8fe782efec
parent 432311 b4eb5da347e5
child 432313 d6cb9fa359e5
push id7929
push userryanvm@gmail.com
push date2017-10-09 18:47 +0000
treeherdermozilla-beta@c4235f5a700c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersxidorn, ritu
bugs1404057
milestone57.0
Bug 1404057 - stylo: `all` shorthand should not apply to internal properties. r=xidorn, a=ritu Source-Repo: https://github.com/servo/servo Source-Revision: 43686a8738513db728eebcc535b5ac6e1a2f17f7
servo/components/style/properties/properties.mako.rs
--- a/servo/components/style/properties/properties.mako.rs
+++ b/servo/components/style/properties/properties.mako.rs
@@ -198,17 +198,19 @@ pub mod shorthands {
     <%include file="/shorthand/padding.mako.rs" />
     <%include file="/shorthand/position.mako.rs" />
     <%include file="/shorthand/inherited_svg.mako.rs" />
     <%include file="/shorthand/text.mako.rs" />
 
     // We don't defined the 'all' shorthand using the regular helpers:shorthand
     // mechanism, since it causes some very large types to be generated.
     <% data.declare_shorthand("all",
-                              [p.name for p in data.longhands if p.name not in ['direction', 'unicode-bidi']],
+                              [p.name for p in data.longhands
+                                if p.name not in ['direction', 'unicode-bidi']
+                                      and not p.internal],
                               spec="https://drafts.csswg.org/css-cascade-3/#all-shorthand") %>
 }
 
 /// A module with all the code related to animated properties.
 ///
 /// This needs to be "included" by mako at least after all longhand modules,
 /// given they populate the global data.
 pub mod animated_properties {